From e2cc7fcaedbc7a653ab80d262a25358d662755e2 Mon Sep 17 00:00:00 2001 From: Tim Meusel Date: Mon, 19 Aug 2024 12:22:20 +0200 Subject: [PATCH 1/4] dev deps: Add strict version contraints --- json-schema.gemspec | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/json-schema.gemspec b/json-schema.gemspec index 33e6bb53..0c930599 100644 --- a/json-schema.gemspec +++ b/json-schema.gemspec @@ -18,9 +18,9 @@ Gem::Specification.new do |s| s.license = 'MIT' s.add_development_dependency 'minitest', '~> 5.0' - s.add_development_dependency 'rake' + s.add_development_dependency 'rake', '~> 13.0' s.add_development_dependency 'voxpupuli-rubocop', '~> 2.8.0' - s.add_development_dependency 'webmock' + s.add_development_dependency 'webmock', '~> 3.23' - s.add_runtime_dependency 'addressable', '>= 2.8' + s.add_runtime_dependency 'addressable', '~> 2.8' end From bd71aca2f69fab8c52b4c6c450b4cd413be7a5d4 Mon Sep 17 00:00:00 2001 From: Tim Meusel Date: Mon, 19 Aug 2024 12:23:05 +0200 Subject: [PATCH 2/4] CI: build gem with strict mode --- .github/workflows/release.yml | 2 +- .github/workflows/test.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 2a706adb..109ec5b0 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -16,7 +16,7 @@ jobs: with: ruby-version: '3.1' - name: Build gem - run: gem build *.gemspec + run: gem build --strict --verbose *.gemspec - name: Publish gem to rubygems.org run: gem push *.gem env: diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index b7ec0cf1..48ed9d29 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -40,7 +40,7 @@ jobs: - name: Run tests run: bundle exec rake ${{ matrix.rake_task }} RUBYOPT="${{ matrix.rubyopt }}" - name: Build gem - run: gem build *.gemspec + run: gem build --strict --verbose *.gemspec tests: needs: - test From e653a065b2625d4ce9f095ac550c8536dd25e16d Mon Sep 17 00:00:00 2001 From: Tim Meusel Date: Mon, 19 Aug 2024 12:23:34 +0200 Subject: [PATCH 3/4] CI: Use Ruby 3.3 for releases --- .github/workflows/release.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 109ec5b0..b71418da 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -11,10 +11,10 @@ jobs: if: github.repository_owner == 'voxpupuli' steps: - uses: actions/checkout@v4 - - name: Install Ruby 3.1 + - name: Install Ruby 3.3 uses: ruby/setup-ruby@v1 with: - ruby-version: '3.1' + ruby-version: '3.3' - name: Build gem run: gem build --strict --verbose *.gemspec - name: Publish gem to rubygems.org From 8fe0c3faf942d38ae261035791c387a12508cf68 Mon Sep 17 00:00:00 2001 From: Tim Meusel Date: Mon, 19 Aug 2024 12:28:27 +0200 Subject: [PATCH 4/4] gemspec: remove homepage_uri This raises the following error: ``` WARNING: You have specified the uri: https://github.com/voxpupuli/json-schema/ for all of the following keys: homepage_uri source_code_uri Only the first one will be shown on rubygems.org ``` --- json-schema.gemspec | 1 - 1 file changed, 1 deletion(-) diff --git a/json-schema.gemspec b/json-schema.gemspec index 0c930599..ddb4a470 100644 --- a/json-schema.gemspec +++ b/json-schema.gemspec @@ -7,7 +7,6 @@ Gem::Specification.new do |s| s.metadata = { 'source_code_uri' => s.homepage, 'changelog_uri' => "#{s.homepage}/blob/master/CHANGELOG.md", - 'homepage_uri' => s.homepage, 'bug_tracker_uri' => "#{s.homepage}/issues", } s.summary = 'Ruby JSON Schema Validator'