refactor: fix ament_cpplint and cppcheck warnings

Author: kluge7

control/dp_adapt_backs_controller/include/dp_adapt_backs_controller/dp_adapt_backs_controller.hpp

@@ -1,11 +1,11 @@
-#ifndef DP_ADAPT_BACKS_CONTROLLER_HPP
-#define DP_ADAPT_BACKS_CONTROLLER_HPP
+#ifndef DP_ADAPT_BACKS_CONTROLLER__DP_ADAPT_BACKS_CONTROLLER_HPP_
+#define DP_ADAPT_BACKS_CONTROLLER__DP_ADAPT_BACKS_CONTROLLER_HPP_
 
 #include "dp_adapt_backs_controller/typedefs.hpp"
 
 class DPAdaptBacksController {
    public:
-    DPAdaptBacksController(const dp_types::DPAdaptParams adap_params);
+    explicit DPAdaptBacksController(const dp_types::DPAdaptParams adap_params);
 
     // @brief Calculate thecontrol input tau
     // @param eta: 6D vector containing the vehicle pose [x, y, z, roll, pitch,
@@ -41,4 +41,4 @@ class DPAdaptBacksController {
     double m_;
     double dt_;
 };
-#endif
+#endif  // DP_ADAPT_BACKS_CONTROLLER__DP_ADAPT_BACKS_CONTROLLER_HPP_

control/dp_adapt_backs_controller/include/dp_adapt_backs_controller/dp_adapt_backs_controller_ros.hpp

@@ -1,16 +1,18 @@
-#ifndef DP_ADAPT_BACKS_CONTROLLER_ROS_HPP
-#define DP_ADAPT_BACKS_CONTROLLER_ROS_HPP
+#ifndef DP_ADAPT_BACKS_CONTROLLER__DP_ADAPT_BACKS_CONTROLLER_ROS_HPP_
+#define DP_ADAPT_BACKS_CONTROLLER__DP_ADAPT_BACKS_CONTROLLER_ROS_HPP_
 
 #include <chrono>
 #include <geometry_msgs/msg/pose_stamped.hpp>
 #include <geometry_msgs/msg/pose_with_covariance_stamped.hpp>
 #include <geometry_msgs/msg/twist_with_covariance_stamped.hpp>
 #include <geometry_msgs/msg/wrench_stamped.hpp>
+#include <memory>
 #include <nav_msgs/msg/odometry.hpp>
 #include <rclcpp/rclcpp.hpp>
 #include <std_msgs/msg/bool.hpp>
 #include <std_msgs/msg/float64_multi_array.hpp>
 #include <std_msgs/msg/string.hpp>
+#include <string>
 #include <vortex_msgs/msg/reference_filter.hpp>
 #include "dp_adapt_backs_controller/dp_adapt_backs_controller.hpp"
 #include "dp_adapt_backs_controller/typedefs.hpp"
@@ -90,4 +92,4 @@ class DPAdaptBacksControllerNode : public rclcpp::Node {
     std::string software_mode_;
 };
 
-#endif
+#endif  // DP_ADAPT_BACKS_CONTROLLER__DP_ADAPT_BACKS_CONTROLLER_ROS_HPP_

control/dp_adapt_backs_controller/include/dp_adapt_backs_controller/dp_adapt_backs_controller_utils.hpp

@@ -1,5 +1,5 @@
-#ifndef DP_ADAPT_BACKS_CONTROLLER_UTILS_HPP
-#define DP_ADAPT_BACKS_CONTROLLER_UTILS_HPP
+#ifndef DP_ADAPT_BACKS_CONTROLLER__DP_ADAPT_BACKS_CONTROLLER_UTILS_HPP_
+#define DP_ADAPT_BACKS_CONTROLLER__DP_ADAPT_BACKS_CONTROLLER_UTILS_HPP_
 
 #include <tf2/LinearMath/Matrix3x3.h>
 #include <tf2/LinearMath/Quaternion.h>
@@ -95,4 +95,4 @@ dp_types::Matrix6d calculate_C(double m,
 // @return 6x6 damping matrix
 dp_types::Matrix6x12d calculate_Y_v(const dp_types::Nu& nu);
 
-#endif
+#endif  // DP_ADAPT_BACKS_CONTROLLER__DP_ADAPT_BACKS_CONTROLLER_UTILS_HPP_

control/dp_adapt_backs_controller/include/dp_adapt_backs_controller/typedefs.hpp

@@ -3,8 +3,8 @@
  * @brief Contains the typedef and structs for the controller.
  */
 
-#ifndef VORTEX_DP_ADAPT_BACKSTEPPING_CONTROLLER_TYPEDEFS_H
-#define VORTEX_DP_ADAPT_BACKSTEPPING_CONTROLLER_TYPEDEFS_H
+#ifndef DP_ADAPT_BACKS_CONTROLLER__TYPEDEFS_HPP_
+#define DP_ADAPT_BACKS_CONTROLLER__TYPEDEFS_HPP_
 
 #include <eigen3/Eigen/Dense>
 
@@ -65,4 +65,4 @@ struct DPAdaptParams {
 
 }  // namespace dp_types
 
-#endif
+#endif  // DP_ADAPT_BACKS_CONTROLLER__TYPEDEFS_HPP_

control/pid_controller_dp/include/pid_controller_dp/pid_controller.hpp

@@ -1,11 +1,11 @@
-#ifndef PID_CONTROLLER_HPP
-#define PID_CONTROLLER_HPP
+#ifndef PID_CONTROLLER_DP__PID_CONTROLLER_HPP_
+#define PID_CONTROLLER_DP__PID_CONTROLLER_HPP_
 
 #include "pid_controller_dp/typedefs.hpp"
 
 class PIDController {
    public:
-    explicit PIDController();
+    PIDController();
 
     // @brief Calculate the control input tau
     // @param eta: struct containing the vehicle pose [position, orientation]
@@ -44,4 +44,4 @@ class PIDController {
     double dt_;
 };
 
-#endif
+#endif  // PID_CONTROLLER_DP__PID_CONTROLLER_HPP_

control/pid_controller_dp/include/pid_controller_dp/pid_controller_conversions.hpp

@@ -1,5 +1,5 @@
-#ifndef PID_CONTROLLER_CONVERSIONS_HPP
-#define PID_CONTROLLER_CONVERSIONS_HPP
+#ifndef PID_CONTROLLER_DP__PID_CONTROLLER_CONVERSIONS_HPP_
+#define PID_CONTROLLER_DP__PID_CONTROLLER_CONVERSIONS_HPP_
 
 #include <cmath>
 #include <eigen3/Eigen/Geometry>
@@ -15,4 +15,4 @@ types::Eta eta_convert_from_ros_to_eigen(
 types::Nu nu_convert_from_ros_to_eigen(
     const geometry_msgs::msg::TwistWithCovarianceStamped::SharedPtr msg);
 
-#endif
+#endif  // PID_CONTROLLER_DP__PID_CONTROLLER_CONVERSIONS_HPP_

control/pid_controller_dp/include/pid_controller_dp/pid_controller_ros.hpp

@@ -1,5 +1,5 @@
-#ifndef PID_CONTROLLER_ROS_HPP
-#define PID_CONTROLLER_ROS_HPP
+#ifndef PID_CONTROLLER_DP__PID_CONTROLLER_ROS_HPP_
+#define PID_CONTROLLER_DP__PID_CONTROLLER_ROS_HPP_
 
 #include <chrono>
 #include <geometry_msgs/msg/pose_stamped.hpp>
@@ -11,6 +11,7 @@
 #include <std_msgs/msg/bool.hpp>
 #include <std_msgs/msg/float64_multi_array.hpp>
 #include <std_msgs/msg/string.hpp>
+#include <string>
 #include <variant>
 #include <vortex_msgs/msg/reference_filter.hpp>
 #include "pid_controller_dp/pid_controller.hpp"
@@ -19,7 +20,7 @@
 // @brief Class for the PID controller node
 class PIDControllerNode : public rclcpp::Node {
    public:
-    explicit PIDControllerNode();
+    PIDControllerNode();
 
    private:
     // @brief Callback function for the killswitch topic
@@ -95,4 +96,4 @@ class PIDControllerNode : public rclcpp::Node {
     std::string software_mode_;
 };
 
-#endif
+#endif  // PID_CONTROLLER_DP__PID_CONTROLLER_ROS_HPP_

control/pid_controller_dp/include/pid_controller_dp/pid_controller_utils.hpp

@@ -1,5 +1,5 @@
-#ifndef PID_UTILS_HPP
-#define PID_UTILS_HPP
+#ifndef PID_CONTROLLER_DP__PID_CONTROLLER_UTILS_HPP_
+#define PID_CONTROLLER_DP__PID_CONTROLLER_UTILS_HPP_
 
 #include <tf2/LinearMath/Matrix3x3.h>
 #include <tf2/LinearMath/Quaternion.h>
@@ -71,4 +71,4 @@ types::Vector7d anti_windup(const double dt,
                             const types::Eta& error,
                             const types::Vector7d& integral);
 
-#endif
+#endif  // PID_CONTROLLER_DP__PID_CONTROLLER_UTILS_HPP_

control/pid_controller_dp/include/pid_controller_dp/typedefs.hpp

@@ -3,8 +3,8 @@
  * @brief Contains the typedef for a 6x1 Eigen vector and a 6x6 Eigen matrix.
  */
 
-#ifndef VORTEX_EIGEN_TYPEDEFS_H
-#define VORTEX_EIGEN_TYPEDEFS_H
+#ifndef PID_CONTROLLER_DP__TYPEDEFS_HPP_
+#define PID_CONTROLLER_DP__TYPEDEFS_HPP_
 
 #include <eigen3/Eigen/Dense>
 
@@ -56,4 +56,4 @@ struct J_transformation {
 };
 }  // namespace types
 
-#endif
+#endif  // PID_CONTROLLER_DP__TYPEDEFS_HPP_

control/pid_controller_dp_euler/include/pid_controller_dp_euler/pid_controller.hpp

@@ -1,11 +1,11 @@
-#ifndef PID_CONTROLLER_HPP
-#define PID_CONTROLLER_HPP
+#ifndef PID_CONTROLLER_DP_EULER__PID_CONTROLLER_HPP_
+#define PID_CONTROLLER_DP_EULER__PID_CONTROLLER_HPP_
 
 #include <pid_controller_dp_euler/typedefs.hpp>
 
 class PIDController {
    public:
-    explicit PIDController();
+    PIDController();
 
     Vector6d calculate_tau(const Eta& eta,
                            const Eta& eta_d,
@@ -28,4 +28,4 @@ class PIDController {
     double dt_;
 };
 
-#endif
+#endif  // PID_CONTROLLER_DP_EULER__PID_CONTROLLER_HPP_