-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API Key #1
Comments
Hey thanks for the report. This usually happens when a new season starts, because the API doesn't return the new season yet, and this app expects a season to be active (otherwise it can't know how many pips you have, or what kind of chests it uses) It's a bit weird though that it's been a week since it started and it's still not coming back.... maybe I'm doing something wrong, but I manually checked and it's not there: https://api.guildwars2.com/v2/pvp/seasons gives the existing season Something that could be improved though is comunicating this to the user... a message/overlay of "No active season found" or something, instead of the UI just not working at all / crashing. |
Yeah, that would be a good idea. Or else currently it looks like the app itself isn't working. Sounds like Anet just hasn't released their newest set yet. Alternative (less awesome) way of handling it is: if the API isn't returning something, you can have the user manually enter the info? "The API isn't returning anything. When does the current season end?" and then you can do your calculations that way? |
I'll give this a go 🚀 |
Released an initial version on https://github.com/voliva/gw2-pvp-pips/releases/tag/v0.3.0, give it a try please! I think the way of entering the current pips you have could be improved... it's a pain to count them by hand. I will have to add in a menu so you can select your current reward chest + pips. Reusing this issue. Edit: I also have more things to fix :'D I've increased the number of pips received by 2 because on last season I was on platinum and I wanted an accurate measurement, but this shouldn't have made it into the release. It would be great to have the feature of setting this up, but it's not part of this issue. |
Looking better! I agree with you that trying to count # of pips is intense lol Maybe you can do something like what they do for WvW? (https://gw2.limitlessfx.com/wvw/pips.php) That might be an idea if you want. (I think people are ok with it being not perfect anyway, as long as it gives a good enough estimate? Especially when the API isn't working) |
During the last season the API key part was working, but now when I try and add it, it won't actually show anything. Also, when I try and click on "Create new goal" everything disappears and I can't do anything.
The text was updated successfully, but these errors were encountered: