Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why do this breaking change in non-Major version? #66

Open
Lykr opened this issue Oct 29, 2024 · 0 comments
Open

Why do this breaking change in non-Major version? #66

Lykr opened this issue Oct 29, 2024 · 0 comments

Comments

@Lykr
Copy link

Lykr commented Oct 29, 2024 •
edited
Loading

ve-tos-golang-sdk/tos/metadata.go

Line 45 in b3188e4

RestoreInfo *RestoreInfo `json:"Restore,omitempty"`

In v2.7.0, "Restore" was renamed to "RestoreInfo", but the Json serialization name was not changed.

See https://semver.org/, "MINOR version when you add functionality in a backward compatible manner", but renaming an attribute is not a backward compatible change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Lykr