vp create vue fails during with TypeError

[hadarziv-army]

Describe the bug

Running vp create vue fails during the project generation step when it executes pnpm dlx create-vue.

The CLI starts normally, prompts for inputs, and proceeds with default selections, but then crashes with a TypeError during the interactive prompt phase.

This prevents creating a new Vue project entirely.

Reproduction

This issue happens during CLI execution, so I cannot provide a minimal reproduction repository.

Steps to reproduce

1. Run vp create vue
2. Accept all default options (press Enter through prompts)
3. Wait for the CLI to run pnpm dlx create-vue
4. Observe the crash

System Info

Environment:
  Version  24.14.0
  Source   lts

Tool Paths:
  node  C:\Users\User\.vite-plus\js_runtime\node\24.14.0\node.exe
  npm   C:\Users\User\.vite-plus\js_runtime\node\24.14.0\npm.cmd
  npx   C:\Users\User\.vite-plus\js_runtime\node\24.14.0\npx.cmd


VITE+ - The Unified Toolchain for the Web

vp v0.1.13

Local vite-plus:
  vite-plus  Not found

Tools:
  vite             Not found
  rolldown         Not found
  vitest           Not found
  oxfmt            Not found
  oxlint           Not found
  oxlint-tsgolint  Not found
  tsdown           Not found

Environment:
  Package manager  Not found
  Node.js          v24.14.0

Used Package Manager

pnpm

Logs

The process crashes with the following error:

TypeError: Cannot read properties of undefined (reading 'length')
    at Object.validate (.../create-vue/bundle.js:3426:30)
    at onKeypress (.../create-vue/bundle.js:499:25)
    ...
Node.js v24.14.0

Validations

• Read the Contributing Guidelines.
• Check that there isn't already an issue for the same bug.
• Confirm this is a Vite+ issue and not an upstream issue (Vite, Vitest, tsdown, Rolldown, or Oxc).
• The provided reproduction is a minimal reproducible example.

[claude]

Analysis

Root Cause

The crash is caused by fspy's Detours DLL injection on Windows interfering with TTY/stdin in the child process.

Here's the execution path for vp create vue:

executeRemoteTemplate()
  → runRemoteTemplateCommand() [remote.ts:96-100, detectCreatedProjectDir=true]
    → runCommandAndDetectProjectDir() [command.ts:22-90]
      → runCommandWithFspy() [NAPI binding → Rust]
        → fspy::Command [uses Windows Detours for FS tracking]

The runCommandAndDetectProjectDir function uses fspy (filesystem access tracking) to detect which directory create-vue created, by hooking all file system calls. On Windows, fspy uses fspy_detours_sys (Microsoft Detours library) to inject a DLL into the child process (pnpm dlx create-vue). This DLL injection alters how Win32 console APIs behave, which breaks Node.js's readline/stdin handling in the child process. As a result, create-vue's interactive prompt library receives undefined instead of keypress strings — causing the TypeError: Cannot read properties of undefined (reading 'length') crash at onKeypress.

Note: On Unix, fspy uses seccomp/LD_PRELOAD (no DLL injection), so this works fine there. A fix_stdio_streams() workaround exists for Unix but there's no equivalent for Windows (vite_command/src/lib.rs:198-230).

---

Is This Fixable?

Yes. The fix is straightforward.

---

Relevant Files

File	Role
packages/cli/src/create/command.ts:22-90	runCommandAndDetectProjectDir — calls fspy
packages/cli/src/create/templates/remote.ts:96-100	Forces detectCreatedProjectDir=true for all remote templates
crates/vite_command/src/lib.rs:134-196	run_command_with_fspy — uses fspy::Command
packages/cli/binding/src/utils.rs:88-120	NAPI binding that exposes runCommand to JS

---

Implementation Plan

In packages/cli/src/create/command.ts, modify runCommandAndDetectProjectDir to use a directory-listing fallback on Windows instead of fspy:

1. Before running the command: snapshot all subdirectories in cwd (this is already done for the parentDir case at lines 27-37 — extend it to always snapshot when on Windows).

2. On Windows, run the command with cross-spawn using stdio: 'inherit' (same as runCommand does at line 127-131) instead of runCommandWithFspy.

3. After the command exits: scan cwd for new subdirectories, check which new ones contain a package.json at the top level. The shallowest match becomes the detected projectDir.

4. On non-Windows, keep the existing fspy path unchanged.

Example sketch:

export async function runCommandAndDetectProjectDir(
  options: RunCommandOptions,
  parentDir?: string,
): Promise<ExecutionResult> {
  const cwd = parentDir ? path.join(options.cwd, parentDir) : options.cwd;
  
  // Always snapshot existing dirs on Windows (needed for fallback detection)
  const existingDirs = new Set<string>();
  if (parentDir || process.platform === 'win32') {
    await fs.mkdir(cwd, { recursive: true });
    const entries = await fs.readdir(cwd, { withFileTypes: true });
    for (const entry of entries) {
      if (entry.isDirectory()) existingDirs.add(entry.name);
    }
  }

  if (process.platform === 'win32') {
    // fspy uses Detours DLL injection on Windows which breaks TTY/stdin
    // in interactive child processes (e.g. create-vue prompts). Use
    // directory listing to detect the created project instead.
    const child = spawn(options.command, options.args, {
      stdio: 'inherit',
      cwd,
      env: options.envs,
    });
    const exitCode = await new Promise<number>((resolve, reject) => {
      child.on('close', (code) => resolve(code ?? 0));
      child.on('error', reject);
    });
    let projectDir: string | undefined;
    const entries = await fs.readdir(cwd, { withFileTypes: true });
    for (const entry of entries) {
      if (entry.isDirectory() && !existingDirs.has(entry.name)) {
        try {
          await fs.access(path.join(cwd, entry.name, 'package.json'));
          projectDir = entry.name;
          break;
        } catch { /* no package.json */ }
      }
    }
    if (parentDir && projectDir) projectDir = path.join(parentDir, projectDir);
    return { exitCode, projectDir };
  }

  // Non-Windows: use fspy for precise detection
  // ... existing code unchanged ...
}

Potential Concerns

• Project dir detection reliability: The directory listing approach is slightly less precise than fspy (fspy tracks exact write events), but is sufficient for all standard create-* scaffolding tools which create exactly one top-level directory.
• Templates that create nested package.json: For templates that write package.json into deeper subdirectories, the listing approach may not detect them. This is an edge case that could be addressed with a recursive scan if needed.
• Future fspy improvement: If fspy_preload_windows is ever fixed to not interfere with console I/O, the Windows fallback can be removed.

[fengmk2]

I think is a issue of create-vue package, you can try it by npx create-vue:

[fengmk2]

vuejs/create-vue#972

[fengmk2]

should works now