Skip to content

Commit f88606f

Browse files
committed
fix(ci): keep rolldown download keyed to runner OS, not Rust target
The rolldown binding is loaded by Node.js on the host runner to run JS build steps (rolldown build-node, vite build-types, etc.), not cross-compiled into the output. Downloading a musl binding on a glibc runner would cause binding.cjs to fail to load.
1 parent 70a02f0 commit f88606f

File tree

1 file changed

+5
-8
lines changed
  • .github/actions/download-rolldown-binaries

1 file changed

+5
-8
lines changed

.github/actions/download-rolldown-binaries/action.yml

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -20,18 +20,15 @@ runs:
2020
- name: Install previous release
2121
shell: bash
2222
run: |
23+
# Always download the binding that matches the runner OS (not the
24+
# Rust cross-compilation target). The rolldown binding is loaded by
25+
# Node.js on the host to run JS build steps, not cross-compiled.
2326
if ${{ runner.os == 'Windows' }}; then
2427
export TARGET="win32-x64-msvc"
28+
elif ${{ runner.os == 'Linux' }}; then
29+
export TARGET="linux-x64-gnu"
2530
elif ${{ runner.os == 'macOS' }}; then
2631
export TARGET="darwin-arm64"
27-
elif [[ "${{ inputs.target }}" == *"musl"* ]]; then
28-
case "${{ inputs.target }}" in
29-
x86_64*) export TARGET="linux-x64-musl" ;;
30-
aarch64*) export TARGET="linux-arm64-musl" ;;
31-
*) echo "Unknown musl target: ${{ inputs.target }}"; exit 1 ;;
32-
esac
33-
else
34-
export TARGET="linux-x64-gnu"
3532
fi
3633
3734
# Pin to the version from checked-out rolldown source to avoid mismatch

0 commit comments

Comments
 (0)