Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inference): pass str instead of Path in sf.load() and sf.write() #769

Merged
merged 1 commit into from
Jun 25, 2023

Conversation

Ph0rk0z
Copy link
Contributor

@Ph0rk0z Ph0rk0z commented Jun 15, 2023

I found this work around as it is a problem with the libraries and librosa.

The PR changes main.py and converts the paths to a string. It shouldn't harm any other OS or cause issues.

I found this work around as it is a problem with the libraries and librosa.
@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (00c9ac4) 19.43% compared to head (af0b492) 19.43%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #769   +/-   ##
=======================================
  Coverage   19.43%   19.43%           
=======================================
  Files          39       39           
  Lines        3452     3452           
  Branches      484      484           
=======================================
  Hits          671      671           
  Misses       2763     2763           
  Partials       18       18           
Impacted Files Coverage Δ
src/so_vits_svc_fork/inference/main.py 14.56% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@34j 34j changed the title Fix file loading and saving for static inference in UI. fix(inference) file loading and saving for static inference in UI. Jun 24, 2023
@34j 34j changed the title fix(inference) file loading and saving for static inference in UI. fix(inference): pass str instead of Path in sf.load() Jun 24, 2023
@34j 34j changed the title fix(inference): pass str instead of Path in sf.load() fix(inference): pass str instead of Path in sf.load() and sf.write() Jun 24, 2023
@34j 34j merged commit 561cbfe into voicepaw:main Jun 25, 2023
@34j
Copy link
Collaborator

34j commented Jun 25, 2023

@allcontributors
add Star3Lord for bug, code
add Ph0rk0z for bug, code

@allcontributors
Copy link
Contributor

@34j

I've put up a pull request to add @Star3Lord! 🎉

I've put up a pull request to add @Ph0rk0z! 🎉

@34j
Copy link
Collaborator

34j commented Jun 25, 2023

@allcontributors
add Ph0rk0z for bug, code

1 similar comment
@34j
Copy link
Collaborator

34j commented Jun 25, 2023

@allcontributors
add Ph0rk0z for bug, code

@allcontributors
Copy link
Contributor

@34j

@Ph0rk0z already contributed before to bug, code

@34j
Copy link
Collaborator

34j commented Jun 25, 2023

@allcontributors
add Ph0rk0z for bug, code

@allcontributors
Copy link
Contributor

@34j

I've put up a pull request to add @Ph0rk0z! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants