Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass string path to librosa and soundfile #558

Closed
wants to merge 1 commit into from

Conversation

Star3Lord
Copy link
Contributor

Summary

Changed path arguments passed to librosa and soundfile functions used in inference to avoid path errors in some environments like temp files in docker containers.

@codecov-commenter
Copy link

codecov-commenter commented May 4, 2023

Codecov Report

Patch coverage: 50.00% and no project coverage change.

Comparison is base (435ca3c) 19.72% compared to head (504497a) 19.72%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #558   +/-   ##
=======================================
  Coverage   19.72%   19.72%           
=======================================
  Files          39       39           
  Lines        3381     3381           
  Branches      464      464           
=======================================
  Hits          667      667           
  Misses       2697     2697           
  Partials       17       17           
Impacted Files Coverage Δ
src/so_vits_svc_fork/inference/main.py 19.71% <0.00%> (ø)
src/so_vits_svc_fork/__init__.py 100.00% <100.00%> (ø)
src/so_vits_svc_fork/logger.py 80.95% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@34j
Copy link
Collaborator

34j commented May 20, 2023

Thanks for the PR.

  • I think there are more places that librosa or soundfile is used.
  • It is disappointing that it does not work with Docker, but I am not sure if this is the best solution.

@Ph0rk0z
Copy link
Contributor

Ph0rk0z commented Jun 15, 2023

ahh crap.. I just re-did this. Yea. it is unusable without these changes. Not a single file will load or save on linux. I don't even use docker.

@34j
Copy link
Collaborator

34j commented Jun 25, 2023

Migrate to #769, sorry

@34j 34j closed this Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants