Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: errors from faucet are wrongly parsed and returned as [object Object] #301

Closed
elboletaire opened this issue Nov 13, 2023 · 0 comments · Fixed by #306
Closed

bug: errors from faucet are wrongly parsed and returned as [object Object] #301

elboletaire opened this issue Nov 13, 2023 · 0 comments · Fixed by #306
Labels
bug Something isn't working

Comments

@elboletaire
Copy link
Member

Describe the bug

When the faucet API returns an error of any kind, it returns a json object of type {error: string}, but the SDK seems to be casting it to string, since errors are returned as [object Object].

To Reproduce

Making a faucet request twice should show the issue, since it should trigger the cooldown error.

Current behavior

A [object Object] string is received as error.

Expected behavior

Receive the proper string from the .error field.

@elboletaire elboletaire added the bug Something isn't working label Nov 13, 2023
marcvelmer added a commit that referenced this issue Nov 15, 2023
marcvelmer added a commit that referenced this issue Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant