Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: api url overwrite does not work on examples #223

Closed
lucasmenendez opened this issue Jul 25, 2023 · 1 comment · Fixed by #224
Closed

bug: api url overwrite does not work on examples #223

lucasmenendez opened this issue Jul 25, 2023 · 1 comment · Fixed by #224
Assignees
@selankon
Labels
bug Something isn't working

Comments

@lucasmenendez
Copy link
Contributor

Describe the bug

The typescript example seems to support SDK Client API_URL overwrite using this flag before yarn start command but it does not work.

I tried to run typescript example over local vocdoni-node but it was connected to STG environment instead.
@lucasmenendez lucasmenendez added the bug Something isn't working label Jul 25, 2023
@selankon
Copy link
Collaborator

The yarn start executes the first example which not support API_URL env variable

https://github.com/vocdoni/vocdoni-sdk/blob/main/examples/typescript/src/index.ts#L48

It can be easily supported by using this function https://github.com/vocdoni/vocdoni-sdk/blob/main/examples/typescript/src/utils/utils.ts#L6

selankon added a commit that referenced this issue Jul 25, 2023
@selankon
Fix #223
55d0ac7
@selankon selankon mentioned this issue Jul 25, 2023
Merged
marcvelmer pushed a commit that referenced this issue Jul 25, 2023
@selankon @marcvelmer
Fix #223
c1c6fee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@selankon selankon

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use API_URL env variable on all the examples vocdoni/vocdoni-sdk
2 participants
@lucasmenendez @selankon