Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added vote checks and modified approval election #352

Merged
merged 5 commits into from
Jan 24, 2024
Merged

Added vote checks and modified approval election #352

merged 5 commits into from
Jan 24, 2024

Conversation

marcvelmer
Copy link
Collaborator

@marcvelmer marcvelmer commented Jan 24, 2024 •
edited
Loading

Closes #206

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 24, 2024 •
edited
Loading

size-limit report 📦

Path Size
dist/index.js 1.54 MB (+0.02% 🔺)
dist/index.mjs 1.54 MB (+0.02% 🔺)
dist/index.umd.js 1.55 MB (+0.02% 🔺)

emmdim
emmdim approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@emmdim emmdim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marcvelmer marcvelmer merged commit fa67058 into main Jan 24, 2024
10 checks passed
@marcvelmer marcvelmer deleted the f/add_vote_checks branch January 24, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elboletaire elboletaire elboletaire approved these changes

@emmdim emmdim emmdim approved these changes

@jpaulet jpaulet Awaiting requested review from jpaulet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vote validity check
3 participants
@marcvelmer @elboletaire @emmdim