Separated queues in GatewayPool for Dvote and Web3 #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed order in WEB3 initial calls for bailing earlier Changed getBlockNums for 'lazy' or 'on demand' usage, only called when required Added custom errors Changed GWs sort criteria Added new TODOs for `initEns` and `isReady` functions
…stent with actual HTTP calls instead of Websocket Added new `isPrepared()` function replacing `isReady()` internal usage Added new TODO in `isPrepared()` for simplifying internal status calls
…romises.allSettled`
…l() of all metrics to be set in each Gateway, achieving a better response time because of doing the old `isUp` in a parallel `Promise.all()` Added some TODOs Changed `tsconfig.json` target `es2020` for 'es6', but needs to be reviewed
Added few conditions for discarding Web3 Gateways Partly refactored GatewayDiscovery class Added few TODOs
…single function that will be removed in the future
Changed DVote Gateways order criteria, now performance time is the preferred metric Refactor some internal DVote Gateway functions and add some docs Added some TODO related to custom error handling
…ility with TODO for removing in the future
Refactor and fixed timeout handling when filtering healthy nodes Added few TODOs and fixed minor things Moved to target ES2020 for using `Promise.allSettled()`
# Conflicts: # .gitignore
…d having separate queues.
…lling the discovery process
…hat call the new functions in the gateway discovery.
Refactor and fixed timeout handling when filtering healthy nodes Added few TODOs and fixed minor things Moved to target ES2020 for using `Promise.allSettled()`
…d having separate queues.
…lling the discovery process
…hat call the new functions in the gateway discovery.
…gatewaypool_queue # Conflicts: # src/net/gateway-discovery.ts # src/net/gateway-dvote.ts # src/net/gateway-web3.ts # src/net/gateway.ts # test/helpers/web3-service.ts # test/integration/block-numbers.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separated queues for both Dvote and Web3 Gateways and refactored
randomFromDefaultandrandomfromUricode into the discovery class.