Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: deprecate VRA7_ environmental variables #530

Merged
merged 1 commit into from
Jul 30, 2024
Merged

chore: deprecate VRA7_ environmental variables #530

merged 1 commit into from
Jul 30, 2024

Conversation

tenthirtyam
Copy link
Contributor

@tenthirtyam tenthirtyam commented Jul 10, 2024 •
edited

Description

  • Updates reauthorize_timeout to accept VRA_INSECURE, and VRA7_INSECURE. Use of VRA7_INSECURE will trigger the depreciation notice.
  • Updates insecure to accept VRA_REAUTHORIZE_TIMEOUT, and VRA7_REAUTHORIZE_TIMEOUT. Use of VRA7_REAUTHORIZE_TIMEOUT will trigger the depreciation notice.
  • Updates documentation.

Reference

Closes #518

@tenthirtyam tenthirtyam self-assigned this Jul 10, 2024
@tenthirtyam tenthirtyam marked this pull request as draft July 10, 2024 05:09
@tenthirtyam tenthirtyam removed the request for review from frodenas July 10, 2024 05:09
@tenthirtyam tenthirtyam marked this pull request as ready for review July 24, 2024 19:14
frodenas
frodenas reviewed Jul 25, 2024
View reviewed changes
vra/provider.go Outdated Show resolved Hide resolved
vra/provider.go Outdated Show resolved Hide resolved
@tenthirtyam tenthirtyam force-pushed the chore/deprecate-envvars branch 2 times, most recently from 6658c82 to 4d52099 Compare July 27, 2024 00:04
@tenthirtyam tenthirtyam force-pushed the chore/deprecate-envvars branch 2 times, most recently from 408be34 to 9a19967 Compare July 27, 2024 00:09
@tenthirtyam tenthirtyam marked this pull request as draft July 27, 2024 00:22
@tenthirtyam
chore: deprecate VRA7_ environmental variables
ae6865e 
- Updates `reauthorize_timeout` to accept `VRA_INSECURE`, and `VRA7_INSECURE`. Use of `VRA7_INSECURE` will trigger the depreciation notice.
- Updates `insecure` to accept `VRA_REAUTHORIZE_TIMEOUT`, and `VRA7_REAUTHORIZE_TIMEOUT`. Use of `VRA7_REAUTHORIZE_TIMEOUT` will trigger the depreciation notice.
- Updates documentation.

Ref: #518

Signed-off-by: Ryan Johnson <[email protected]>
@tenthirtyam tenthirtyam marked this pull request as ready for review July 27, 2024 05:51
@tenthirtyam
Copy link
Contributor Author

tenthirtyam commented Jul 27, 2024 •
edited

@frodenas - updated, but still need to test.

frodenas
frodenas approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@frodenas frodenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I successfully tested these changes on my local environment.

@frodenas frodenas merged commit e84f313 into main Jul 30, 2024
2 checks passed
@frodenas frodenas deleted the chore/deprecate-envvars branch July 30, 2024 18:51
@tenthirtyam
Copy link
Contributor Author

Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frodenas frodenas frodenas approved these changes

Assignees

@tenthirtyam tenthirtyam

Labels
chore Chore documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

References to VRA7_ need to be updated
2 participants
@tenthirtyam @frodenas