Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

References to VRA7_ need to be updated #518

Closed
1 task
MasakariDOR opened this issue Apr 3, 2024 · 0 comments · Fixed by #530
Closed
1 task

References to VRA7_ need to be updated #518

MasakariDOR opened this issue Apr 3, 2024 · 0 comments · Fixed by #530
Assignees
@tenthirtyam
Labels
chore Chore documentation

Comments

@MasakariDOR
Copy link

Code of Conduct

This project has a Code of Conduct that all participants are expected to understand and follow:

vRA Version

8.16.0.33697

Terraform Version

1.5.2

vRA Terraform Provider Version

0.8.7

Affected Resource(s)

N/A

Terraform Configuration Files

N/A

# Copy-paste your Terraform configurations here.
# For large Terraform configs, please use a service like Dropbox and share a link to the ZIP file.

Expected Behavior

Expect that provider environment variables VRA7_INSECURE and VRA7_REAUTHORIZE_TIMEOUT be renamed to VRA_INSECURE and VRA_REAUTHORIZE_TIMEOUT.

Actual Behavior

Environment variables have not been updated since VRA7.

Steps to Reproduce

Screenshots

Debug Output

Panic Output

Important Factoids

References

https://github.com/vmware/terraform-provider-vra/blob/main/vra/provider.go#L35
https://github.com/vmware/terraform-provider-vra/blob/main/vra/provider.go#L41

terraform-provider-vra/website/docs/index.html.markdown

Line 69 in 7dab487

* `insecure` - (Optional) This specifies whether if the TLS certificates are validated. Can also be specified with the `VRA7_INSECURE` environment variable.

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
@MasakariDOR MasakariDOR added bug Something isn't working needs-triage labels Apr 3, 2024
@tenthirtyam tenthirtyam self-assigned this Jul 9, 2024
tenthirtyam added a commit that referenced this issue Jul 10, 2024
@tenthirtyam
chore: deprecate VRA7_ environmental variables
eb35e7c 
- Adds `envDefaultFunc` helper function to create a `schema.DefaultFunc` to read the values from the environment variables. This allows the provider to accept, but deprecate legacy environmental variables.
- Updates `reauthorize_timeout` to accept `VRA_INSECURE`, and `VRA7_INSECURE`. Use of `VRA7_INSECURE` will trigger the depreciation notice.
- Updates `insecure` to accept `VRA_REAUTHORIZE_TIMEOUT`, and `VRA7_REAUTHORIZE_TIMEOUT`. Use of `VRA7_REAUTHORIZE_TIMEOUT` will trigger the depreciation notice.
- Updates documentation.

Ref: #518

Signed-off-by: Ryan Johnson <[email protected]>
@tenthirtyam tenthirtyam mentioned this issue Jul 10, 2024
Merged
@tenthirtyam tenthirtyam added documentation chore Chore and removed needs-triage bug Something isn't working labels Jul 10, 2024
@tenthirtyam tenthirtyam changed the title References to vRA7 need to be updated References to VRA7_ need to be updated Jul 10, 2024
tenthirtyam added a commit that referenced this issue Jul 11, 2024
@tenthirtyam
chore: deprecate VRA7_ environmental variables
96f9995 
- Adds `envDefaultFunc` helper function to create a `schema.DefaultFunc` to read the values from the environment variables. This allows the provider to accept, but deprecate legacy environmental variables.
- Updates `reauthorize_timeout` to accept `VRA_INSECURE`, and `VRA7_INSECURE`. Use of `VRA7_INSECURE` will trigger the depreciation notice.
- Updates `insecure` to accept `VRA_REAUTHORIZE_TIMEOUT`, and `VRA7_REAUTHORIZE_TIMEOUT`. Use of `VRA7_REAUTHORIZE_TIMEOUT` will trigger the depreciation notice.
- Updates documentation.

Ref: #518

Signed-off-by: Ryan Johnson <[email protected]>
tenthirtyam added a commit that referenced this issue Jul 27, 2024
@tenthirtyam
chore: deprecate VRA7_ environmental variables
6658c82 
- Updates `reauthorize_timeout` to accept `VRA_INSECURE`, and `VRA7_INSECURE`. Use of `VRA7_INSECURE` will trigger the depreciation notice.
- Updates `insecure` to accept `VRA_REAUTHORIZE_TIMEOUT`, and `VRA7_REAUTHORIZE_TIMEOUT`. Use of `VRA7_REAUTHORIZE_TIMEOUT` will trigger the depreciation notice.
- Updates documentation.

Ref: #518

Signed-off-by: Ryan Johnson <[email protected]>
tenthirtyam added a commit that referenced this issue Jul 27, 2024
@tenthirtyam
chore: deprecate VRA7_ environmental variables
4d52099 
- Updates `reauthorize_timeout` to accept `VRA_INSECURE`, and `VRA7_INSECURE`. Use of `VRA7_INSECURE` will trigger the depreciation notice.
- Updates `insecure` to accept `VRA_REAUTHORIZE_TIMEOUT`, and `VRA7_REAUTHORIZE_TIMEOUT`. Use of `VRA7_REAUTHORIZE_TIMEOUT` will trigger the depreciation notice.
- Updates documentation.

Ref: #518

Signed-off-by: Ryan Johnson <[email protected]>
tenthirtyam added a commit that referenced this issue Jul 27, 2024
@tenthirtyam
chore: deprecate VRA7_ environmental variables
408be34 
- Updates `reauthorize_timeout` to accept `VRA_INSECURE`, and `VRA7_INSECURE`. Use of `VRA7_INSECURE` will trigger the depreciation notice.
- Updates `insecure` to accept `VRA_REAUTHORIZE_TIMEOUT`, and `VRA7_REAUTHORIZE_TIMEOUT`. Use of `VRA7_REAUTHORIZE_TIMEOUT` will trigger the depreciation notice.
- Updates documentation.

Ref: #518

Signed-off-by: Ryan Johnson <[email protected]>
tenthirtyam added a commit that referenced this issue Jul 27, 2024
@tenthirtyam
chore: deprecate VRA7_ environmental variables
9a19967 
- Updates `reauthorize_timeout` to accept `VRA_INSECURE`, and `VRA7_INSECURE`. Use of `VRA7_INSECURE` will trigger the depreciation notice.
- Updates `insecure` to accept `VRA_REAUTHORIZE_TIMEOUT`, and `VRA7_REAUTHORIZE_TIMEOUT`. Use of `VRA7_REAUTHORIZE_TIMEOUT` will trigger the depreciation notice.
- Updates documentation.

Ref: #518

Signed-off-by: Ryan Johnson <[email protected]>
tenthirtyam added a commit that referenced this issue Jul 27, 2024
@tenthirtyam
chore: deprecate VRA7_ environmental variables
ae6865e 
- Updates `reauthorize_timeout` to accept `VRA_INSECURE`, and `VRA7_INSECURE`. Use of `VRA7_INSECURE` will trigger the depreciation notice.
- Updates `insecure` to accept `VRA_REAUTHORIZE_TIMEOUT`, and `VRA7_REAUTHORIZE_TIMEOUT`. Use of `VRA7_REAUTHORIZE_TIMEOUT` will trigger the depreciation notice.
- Updates documentation.

Ref: #518

Signed-off-by: Ryan Johnson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tenthirtyam tenthirtyam

Labels
chore Chore documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: deprecate VRA7_ environmental variables vmware/terraform-provider-vra
2 participants
@tenthirtyam @MasakariDOR