Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canvas Item Support for End Workflow #340

Closed
Michaelpalacce opened this issue Jul 16, 2024 · 1 comment
Closed

Canvas Item Support for End Workflow #340

Michaelpalacce opened this issue Jul 16, 2024 · 1 comment
Assignees
Labels
area/vrotsc Relates to `vrotsc` module effort/low kind/feature New Feature to the project lang/typescript Related to typescript code priority/medium triage/needed Needs to be discussed by project maintainers

Comments

@Michaelpalacce
Copy link
Collaborator

Michaelpalacce commented Jul 16, 2024

Description

We need to add support for "End workflow" elements, they are used to define "ends" of the wf.

Example

Workflow ends can be one of two kinds:

Normal Ends:

  <workflow-item name="item6" business-status="Test Business status" type="end" end-mode="0">
    <in-binding/>
    <position y="50.0" x="400.0"/>
  </workflow-item>

Exception ends:

  <workflow-item name="item5" business-status="Bad" throw-bind-name="errorBind" type="end" end-mode="1">
    <in-binding/>
    <position y="210.0" x="320.0"/>
  </workflow-item>

Notes

  • We need to support both kinds of end
  • business-status is completely optional, so it should be the same for us.
  • end-mode signifies if it's good or bad. 1 means exception, 0 means normal end.
  • type is always end
  • throw-bind-name is the string variable that contains the error. Treat this as a normal attribute/input/output
  • There will always be a default "end" that is targetable by passing "end" to the target, this will stay as is and will always be the last element that is generated.
@Michaelpalacce Michaelpalacce added lang/typescript Related to typescript code area/vrotsc Relates to `vrotsc` module triage/needed Needs to be discussed by project maintainers kind/feature New Feature to the project priority/medium effort/medium effort/low and removed effort/medium labels Jul 16, 2024
@akantchev akantchev self-assigned this Jul 17, 2024
@akantchev
Copy link
Contributor

Implementation: #348

akantchev added a commit that referenced this issue Jul 22, 2024
[vrotsc] (#340) Added a new canvas item for workflow end.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/vrotsc Relates to `vrotsc` module effort/low kind/feature New Feature to the project lang/typescript Related to typescript code priority/medium triage/needed Needs to be discussed by project maintainers
Projects
None yet
Development

No branches or pull requests

2 participants