Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vro-scripting-api Needs to be split up #304

Open
Michaelpalacce opened this issue Jul 11, 2024 · 4 comments
Open

vro-scripting-api Needs to be split up #304

Michaelpalacce opened this issue Jul 11, 2024 · 4 comments
Labels
area/vro-scripting-api Relates to the vro-scripting-api module kind/refactor Refactoring of existing features lang/typescript Related to typescript code triage/blocked This issue is blocked by another, specified in the description
Milestone

Comments

@Michaelpalacce
Copy link
Collaborator

Description

The vro-scripting-api contains 2 parts to it.

  1. To create the test bed and everything associated to running it
  2. To provide declarations for the tests to run
  • Realistically the declarations for the tests to run can potentially be used for providing definitions for writing code in general ( what vro-types is)

What we want to do:

  1. Split up the two components, potentially in different submodules
  2. Remove namespaces from typescript code, it's a bad practice
  3. The split API needs to be put in separate directories by plugin.
    • We don't need to separate it in different submodules as vro-types is, but we want to put the code in separate folders similar to how vro-types is separated

In the future, we want to see if we can use the generated definitions of the vro scripting api (just the "api", not the cli component, hence the split) instead of the ones in vro-types.

How to handle this task.

This task needs to be split up in a few parts that are dependent on the previous step
1. Remove namespaces
2. Split the code in 2 parts: API and CLI

@Michaelpalacce Michaelpalacce added lang/typescript Related to typescript code area/vro-scripting-api Relates to the vro-scripting-api module triage/needed Needs to be discussed by project maintainers labels Jul 11, 2024
@Michaelpalacce Michaelpalacce added this to the 3.0.0 milestone Jul 11, 2024
@Michaelpalacce Michaelpalacce added the kind/refactor Refactoring of existing features label Jul 11, 2024
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Sep 12, 2024
Copy link

This issue was closed because it has been stalled for 7 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 19, 2024
@Michaelpalacce
Copy link
Collaborator Author

Reopening for now

@Michaelpalacce Michaelpalacce added triage/blocked This issue is blocked by another, specified in the description and removed triage/needed Needs to be discussed by project maintainers labels Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/vro-scripting-api Relates to the vro-scripting-api module kind/refactor Refactoring of existing features lang/typescript Related to typescript code triage/blocked This issue is blocked by another, specified in the description
Projects
None yet
Development

No branches or pull requests

1 participant