Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge velero restore helper into velero image #8484

Open
ywk253100 opened this issue Dec 5, 2024 · 2 comments
Open

Merge velero restore helper into velero image #8484

ywk253100 opened this issue Dec 5, 2024 · 2 comments
Assignees
Labels
downstream-integration The issue originated from downstream integration
Milestone

Comments

@ywk253100
Copy link
Contributor

Currently, there are three binaries in Velero: velero, velero-helper and velero-restore-helper. velero and velero-helper are packaged in the same velero image, velero-restore-helper is in a separate velero-restore-helper image.

Velero image can be set by the --image option while there is no such option for velero-restore-helper, users need to set it via a configmap.

I'd like to suggest we merge the velero-restore-helper into the velero image so that users don't need to set the images with different ways.

Velero server can read the image info via the container field environment variable: https://kubernetes.io/docs/tasks/inject-data-application/environment-variable-expose-pod-information/#use-container-fields-as-values-for-environment-variables

What's more, this is helpful when Velero is consumed in the downstream project.
For example, when packaging the Velero as a Carvel package, Carvel tool (imgpkg) can move the package bundle into different registries and deploy the package without modifying the image reference in the yaml files.

Vote on this issue!

This is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here.
Use the "reaction smiley face" up to the right of this comment to vote.

  • 👍 for "I would like to see this bug fixed as soon as possible"
  • 👎 for "There are more important bugs to focus on right now"
@ywk253100 ywk253100 added downstream-integration The issue originated from downstream integration 1.16-candidate labels Dec 5, 2024
@kaovilai
Copy link
Member

kaovilai commented Dec 5, 2024

No performance impact if pull policy is IfNotExist if I understand correctly

@reasonerjt
Copy link
Contributor

reasonerjt commented Dec 6, 2024

to fix #8229 I plan to add "restricted" security context to restore-helper by default, this may impact the image of velero if we want to combine these two images.
see #8491

@reasonerjt reasonerjt added this to the v1.16 milestone Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
downstream-integration The issue originated from downstream integration
Projects
None yet
Development

No branches or pull requests

3 participants