Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use debug.BuildInfo instead of stamping SHA #1950

Open
wilsonehusin opened this issue Dec 11, 2023 · 0 comments
Open

Use debug.BuildInfo instead of stamping SHA #1950

wilsonehusin opened this issue Dec 11, 2023 · 0 comments

Comments

@wilsonehusin
Copy link
Contributor

Describe the solution you'd like

Instead of stamping with -ldflags for Git SHA of a build, we can use debug.BuildInfo to retrieve the vcs.revision1 value for better integrity of build metadata.

Anything else you would like to add:

Happy to contribute the changes if desired, though would like to hear what maintainers think first :) This started as a discussion over at NixOS/nixpkgs#272983 where NixOS builds Sonobuoy from source.

Environment:

  • Sonobuoy version: N/A
  • Kubernetes version: (use kubectl version): N/A
  • Kubernetes installer & version: N/A
  • Cloud provider or hardware configuration: N/A
  • OS (e.g. from /etc/os-release): N/A

Footnotes

  1. https://shibumi.dev/posts/go-18-feature/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant