Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make use of features in controller-runtime v0.5.1 #26

Open
1 of 2 tasks
edwardecook opened this issue Mar 12, 2020 · 0 comments
Open
1 of 2 tasks

Make use of features in controller-runtime v0.5.1 #26

edwardecook opened this issue Mar 12, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@edwardecook
Copy link
Contributor

edwardecook commented Mar 12, 2020 •
edited by gmrodgers
Loading

There is a new release of controller-runtime, v0.5.1, that contains a couple of features which look like they are potentially of interest to us:

  • Add controllerutil.SetOwnerReference
  • Webhook support in envtest

controllerutil.SetOwnerReference in particular is of interest as we are currently using controllerutil.SetControllerReference to set non-controller OwnerRefs which is a slight misuse of the function. The webhook support in envtest should help us improve our tests to just be local.

Note: there is a dependabot PR that contains the bump to v0.5.1, #24.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@edwardecook @MirahImage