Skip to content
This repository has been archived by the owner on Mar 15, 2022. It is now read-only.

Consider subpackage for various checks #15

Open
unkaktus opened this issue Feb 14, 2018 · 2 comments
Open

Consider subpackage for various checks #15

unkaktus opened this issue Feb 14, 2018 · 2 comments

Comments

@unkaktus
Copy link

At the moment if one doesn't want to have specific checks from this package but they have to depend on them (e.g. prometheus) and vendor them accordingly.
It would be nice to have separate subpackages with handlers and with checks to avoid this situation.

@mattmoyer
Copy link
Contributor

I agree that splitting out the metrics handler to a subpackage would be a good idea. That could avoid bringing in the prometheus dependency if you're not using it. The other checks are pretty lightweight in terms of dependencies, but splitting them out wouldn't hurt either.

@unkaktus
Copy link
Author

unkaktus commented Mar 6, 2018

@mattmoyer the problem here is that such a change will break API. At the moment there is no versioning in place (that could make it possible to just bump major version). See #18.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants