You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Mar 15, 2022. It is now read-only.
At the moment if one doesn't want to have specific checks from this package but they have to depend on them (e.g. prometheus) and vendor them accordingly.
It would be nice to have separate subpackages with handlers and with checks to avoid this situation.
The text was updated successfully, but these errors were encountered:
I agree that splitting out the metrics handler to a subpackage would be a good idea. That could avoid bringing in the prometheus dependency if you're not using it. The other checks are pretty lightweight in terms of dependencies, but splitting them out wouldn't hurt either.
@mattmoyer the problem here is that such a change will break API. At the moment there is no versioning in place (that could make it possible to just bump major version). See #18.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
At the moment if one doesn't want to have specific checks from this package but they have to depend on them (e.g. prometheus) and vendor them accordingly.
It would be nice to have separate subpackages with handlers and with checks to avoid this situation.
The text was updated successfully, but these errors were encountered: