Version number - fix recent issue; move version property to gradle.properties (#156)

* fix issue introduced with recent PR - finalzie static class
refactor - cleanup

* move version property from build.gradle to gradle.properties file
clean writeversion task

Author: Pitterling

build.gradle

@@ -9,7 +9,7 @@ apply plugin: 'checkstyle'
 
 group = 'com.github.vlsi.ksar'
 archivesBaseName = 'ksar'
-version = '5.2.4-SNAPSHOT'
+
 
 sourceCompatibility = '1.8'
 targetCompatibility = '1.8'
@@ -33,11 +33,7 @@ dependencies {
 }
 
 task writeVersion << {
-    def s = version.find(/^\d.\d.\d/)
-    if (s == null) {
-        throw new InvalidUserDataException('Invalid version format')
-    }
-    new File("build/resources/main/kSar.version").text = s
+    new File("build/resources/main/kSar.version").text = version
 }
 classes.dependsOn(writeVersion)
 

gradle.properties

@@ -0,0 +1,6 @@
+#
+# Copyright 2018 The kSAR Project. All rights reserved.
+# See the LICENSE file in the project root for more information.
+#
+
+version = 5.2.4-SNAPSHOT

src/main/java/net/atomique/ksar/VersionNumber.java

@@ -13,31 +13,27 @@
 import java.io.InputStream;
 import java.io.InputStreamReader;
 
-public class VersionNumber {
+public final class VersionNumber {
 
   private static final Logger log = LoggerFactory.getLogger(VersionNumber.class);
 
-  private VersionNumber() {
+  static {
+
     StringBuilder tmpstr = new StringBuilder();
-    BufferedReader reader = null;
-    try {
-      InputStream is = this.getClass().getResourceAsStream("/kSar.version");
-      InputStreamReader isr = new InputStreamReader(is);
-      reader = new BufferedReader(isr);
-      String line = "";
+
+    InputStream is = VersionNumber.class.getClassLoader().getResourceAsStream("kSar.version");
+    try (BufferedReader reader = new BufferedReader(new InputStreamReader(is))) {
+
+      String line;
       while ((line = reader.readLine()) != null) {
         tmpstr.append(line);
       }
-      reader.close();
+
+      version_string = tmpstr.toString();
+
     } catch (IOException ex) {
-      log.error("Unable to read Current version", ex);
-      return;
+      log.error("Unable to read ksar version", ex);
     }
-    setVersionNumber(tmpstr.toString());
-  }
-
-  private static void setVersionNumber(String version) {
-    version_string = version;
   }
 
   public static String getVersionString() {