Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core][distributed] add pynccl broadcast #10843

Merged
merged 6 commits into from
Dec 3, 2024

Conversation

youkaichao
Copy link
Member

No description provided.

Signed-off-by: youkaichao <[email protected]>
Signed-off-by: youkaichao <[email protected]>
Signed-off-by: youkaichao <[email protected]>
Signed-off-by: youkaichao <[email protected]>
Copy link

github-actions bot commented Dec 3, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

Copy link
Collaborator

@tlrmchlsmth tlrmchlsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

I noticed that many of the tests in test_pynncl are checking the mean when it looks like they ought to be all the same -- we can fix it up in a follow-up

tests/distributed/test_pynccl.py Outdated Show resolved Hide resolved
Signed-off-by: youkaichao <[email protected]>
@youkaichao
Copy link
Member Author

many of the tests in test_pynncl are checking the mean when it looks like they ought to be all the same -- we can fix it up in a follow-up

agree. this is just historical code. welcome to update it.

@youkaichao youkaichao enabled auto-merge (squash) December 3, 2024 01:18
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 3, 2024
Signed-off-by: youkaichao <[email protected]>
@youkaichao youkaichao merged commit 21fe7b4 into vllm-project:main Dec 3, 2024
53 of 54 checks passed
@youkaichao youkaichao deleted the pynccl_broadcast branch December 3, 2024 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants