Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] How to access the vLLM-Vineyard integration code mentioned in Distributed KV Cache documentation? #733

Open
cheyang opened this issue Feb 24, 2025 · 2 comments
Labels
kind/support Categorizes issue as a support question.

Comments

@cheyang
Copy link

cheyang commented Feb 24, 2025

The Distributed KV Cache documentation references a customized vLLM implementation with Vineyard integration.

However, I couldn't locate the corresponding code implementation.

Could you help me clarify:

  1. Is the customized vLLM code with Vineyard support publicly accessible?
  2. If available, is it in a separate branch/repository?
@gaocegege
Copy link
Collaborator

gaocegege commented Feb 24, 2025

Hi Yang,

fmt.Sprintf(`/usr/local/bin/vineyardd --sync_crds true --socket /var/run/vineyard.sock --size --stream_threshold 80 --etcd_cmd etcd --etcd_prefix /vineyard --etcd_endpoint http://%s-etcd-service:2379`, kvCache.Name),

I think it uses a customized vllm, something like vllm-project/vllm@main...aibrix:vllm:feat/distributed-kv-cache

From what I understand, this only works with v0.6.x of vLLM.

@Jeffwan
Copy link
Collaborator

Jeffwan commented Feb 24, 2025

Great to see you here @cheyang long time no see. Yeah, @gaocegege gave the code pointer in vLLM.

  1. vLLM code will be refactor to adapt to v1 architecture and a RFC will be cut soon. this part will be definitely upstreamed.
  2. @DwyaneShi made some changes like metadata optimization and advanced eviction policies in vineyard. @DwyaneShi feel free to comment if you have more information like to share.

@Jeffwan Jeffwan added the kind/support Categorizes issue as a support question. label Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/support Categorizes issue as a support question.
Projects
None yet
Development

No branches or pull requests

3 participants