Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New vector methods: NormalizeInPlace #186

Open
vkostyukov opened this issue May 22, 2014 · 5 comments
Open

New vector methods: NormalizeInPlace #186

vkostyukov opened this issue May 22, 2014 · 5 comments

Comments

@vkostyukov
Copy link
Owner

Vector {
  Vector normalize(VectorAccumulator acc);
  void normalizeInPlace(VectorAccumulator acc);
}
@vkostyukov vkostyukov added this to the la4j-0.5.0 milestone May 22, 2014
@SamoylovMD
Copy link
Contributor

Does 'normalize' mean construction of a vector with length equals 1 or something else? I'm not fully understand why do we need VectorAccumulator as method argument.

@vkostyukov
Copy link
Owner Author

Normalize means divide the vector by it's norm. We need accumulator in order to pass a norm-function.

@vkostyukov
Copy link
Owner Author

Please, note that we don't need in-place version for upcoming release.

@DWiechert DWiechert mentioned this issue Dec 3, 2014
@DWiechert
Copy link
Contributor

Just leaving a note here that:

Vector normalize()
Vector normalize(VectorAccumulator acc)

were both added in #206 however:

void normalizeInPlace(VectorAccumulator acc)

was not.

@vkostyukov vkostyukov changed the title New vector methods: Normalize and NormalizeInPlace New vector methods: NormalizeInPlace Dec 3, 2014
@vkostyukov vkostyukov modified the milestones: la4j-0.6.0, la4j-0.5.0 Dec 3, 2014
@vkostyukov
Copy link
Owner Author

Moving the rest of this task to the next milestone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants