Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip_before_filter is deprecated #3

Open
ecmrauh opened this issue Sep 23, 2019 · 0 comments
Open

skip_before_filter is deprecated #3

ecmrauh opened this issue Sep 23, 2019 · 0 comments

Comments

@ecmrauh
Copy link

ecmrauh commented Sep 23, 2019

Hi,
as mentioned here, the usage of skip_before_filter is deprecated and should be avoided. So the following call doesn't work with the current Rails version.

skip_before_filter :check_if_login_required

Regarding this, I have a related question. Is this call necessary at all? The class AccountRemoteUserController is derived from AccountController where (its successor skip_before_action) is called, too:

https://github.com/redmine/redmine/blob/3aef7783423fc47a987bad6df060ad69a06221dc/app/controllers/account_controller.rb#L27

Sorry, I'm just using this plugin but don't have any Ruby skills...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant