Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(runner): limit max concurrency without p-limit as a dependency #5980

Merged
merged 1 commit into from
Jun 30, 2024
Merged

refactor(runner): limit max concurrency without p-limit as a dependency #5980

merged 1 commit into from
Jun 30, 2024

Conversation

jviide
Copy link
Contributor

@jviide jviide commented Jun 26, 2024

Description

This pull request implements the concurrency limit with a small utility module, which allows removing the "p-limit" package from @vitest/runner's dependencies.

The utility module is added under packages/runner/src/utils/limit-concurrency.ts.

The "p-limit" package is removed from the dependencies, and pnpm-lock.yaml file is updated accordingly.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@sheremet-va sheremet-va merged commit d066ba9 into vitest-dev:main Jun 30, 2024
14 of 16 checks passed
@sheremet-va
Copy link
Member

Thank you!

@jviide jviide deleted the limit-concurrency branch June 30, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants