Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress dynamic import cannot be analyzed by Vite warning for dynamic imports with /* webpackIgnore: true */ #17578

Closed
4 tasks done
remorses opened this issue Jun 27, 2024 · 1 comment

Comments

@remorses
Copy link
Contributor

Description

Many npm dependencies use /* webpackIgnore: true */ to suppress webpack warnings about non analyzable dynamic imports

Suggested solution

Support /* webpackIgnore: true */ as an alias to /* @vite-ignore */

Alternative

No response

Additional context

No response

Validations

@remorses remorses changed the title Support warning for dynamic imports if /* webpackIgnore: true */ exists Suppress dynamic import cannot be analyzed by Vite warning for dynamic imports with /* webpackIgnore: true */ Jun 27, 2024
@sapphi-red
Copy link
Member

I don't think we should do this. Those package authors have tested with Webpack, but that doesn't mean it would work with Vite. Suppressing the warning would hide potential errors.

@patak-dev patak-dev closed this as not planned Won't fix, can't repro, duplicate, stale Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants