Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(create-vite): add vue-devtools in vue template #17546

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

webfansplz
Copy link
Contributor

Description

👋 Hi team. After discussing with @yyx990803, we plan to add the vue-devtools vite plugin to the create-vite's template-vue. Here's a snapshot and repository of it.

repo: https://github.com/vuejs/devtools-next
docs: https://github.com/vuejs/devtools-next
snapshot:

vue-devtools

Copy link

stackblitz bot commented Jun 23, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@bluwy
Copy link
Member

bluwy commented Jun 24, 2024

If the Vue team decides that they want to include devtools in starters, then I can't argue with that, but are we sure we want to introduce a large installation size for the starter?

image

@btea
Copy link
Collaborator

btea commented Jun 25, 2024

Maybe we can refer to create-vue and add an option for developers to decide whether to add it?

@patak-dev patak-dev added feat: create-vite create-vite package p2-to-be-discussed Enhancement under consideration (priority) labels Jul 1, 2024
@patak-dev
Copy link
Member

Added this to our project board, so we can talk with Evan in the next team meeting. I agree with @bluwy that this will be too much for the Vite starter as we are also using it for reproductions. @webfansplz is this added already to create-vue? I think that is a better place for this plugin, and we already suggest users that if they want to start a new Vue production app, they should use pnpm create vue instead of create vite.

@webfansplz
Copy link
Contributor Author

Added this to our project board, so we can talk with Evan in the next team meeting. I agree with @bluwy that this will be too much for the Vite starter as we are also using it for reproductions. @webfansplz is this added already to create-vue? I think that is a better place for this plugin, and we already suggest users that if they want to start a new Vue production app, they should use pnpm create vue instead of create vite.

Thank you. I agree with the team's trade-off between the starter template and size, it's a good point. Let's go ahead and finalize based on the meeting discussion. (create-vue CLI has been running it as an experimental option for a while now, and I think we're about to remove the experimental flag.)

@patak-dev
Copy link
Member

@webfansplz we discussed this in today's team meeting and confirmed that we'd like to keep the Vite starters lightweight. Would you like to change this PR to recommend the setup as a tip in the readme? (maybe mention that you can use the extension too instead of a plugin)

@webfansplz
Copy link
Contributor Author

@webfansplz we discussed this in today's team meeting and confirmed that we'd like to keep the Vite starters lightweight. Would you like to change this PR to recommend the setup as a tip in the readme? (maybe mention that you can use the extension too instead of a plugin)

Oh, I'm sorry, I forgot to reply. That's no problem. I'll update it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: create-vite create-vite package p2-to-be-discussed Enhancement under consideration (priority)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants