fix(middleware): fix cache issue for import.meta.env in node_modules

[smeng9]

Closes #17505

[stackblitz]

Run & review this pull request in StackBlitz Codeflow.

[smeng9]

We probably need to check if this PR will affect the performance of vite because it tries to perform the search of the string in all code returned.

We also need to check if import.meta.env is the only variable we should search for. It is possible there are other defined variables that should not be cached.

[ArnaudBarre]

import.meta.env is Vite specific, I'm not sure we want it to be supported in node_modules

[smeng9]

I agree that the import.meta.env is vite specific.

However we should still make sure the caches are handled correctly.

[ArnaudBarre]

No merging this kind of code will mean that we encourage the pattern, which we don't want.
And I'm not sure just disabling cache control is enough, you will probably need something else to ensure the chunk is re-computed.
And an adding extra string.includes on all deps code for eveyone just for a small edge case feel bad too.

What you need is to exclude the deps from pre-bundling to be treated more like user code: https://vitejs.dev/config/dep-optimization-options.html#optimizedeps-exclude

[smeng9]

This merge request is not optimal. We will apply your workaround for the edge case for now.