[4.4.1] After update from 4.3.9, server crashes when changing .env file

[SiNONiMiTY]

Describe the bug

Previously on 4.3.9, when I change .env file, server restarts successfully

After upgrading to the latest version, server crashes when .env is changed

BEFORE

AFTER

  VITE v4.4.1  ready in 1272 ms

  ➜  Local:   http://localhost:5173/     
  ➜  Network: http://169.254.35.252:5173/
  ➜  Network: http://192.168.10.165:5173/
  ➜  Network: http://172.31.96.1:5173/   
  ➜  press h to show help
1:09:14 AM [vite] .env changed, restarting server...

const err = new Error('The server is being restarted or closed. Request is outdated');
                ^

Error: The server is being restarted or closed. Request is outdated
    at throwClosedServerError (node_modules/.pnpm/[email protected]_@[email protected]/node_modules/vite/dist/node/chunks/dep-439026c8.js:43694:17)
    at loadAndTransform (node_modules/.pnpm/[email protected]_@[email protected]/node_modules/vite/dist/node/chunks/dep-439026c8.js:54807:9)
    at async instantiateModule (node_modules/.pnpm/[email protected]_@[email protected]/node_modules/vite/dist/node/chunks/dep-439026c8.js:55738:10) {
  code: 'ERR_CLOSED_SERVER'
}

Node.js v18.16.0

Reproduction

StackBlitz

Steps to reproduce

Change .env file while vite server is running

System Info

System:
    OS: Windows 10 10.0.19045
    CPU: (12) x64 AMD Ryzen 5 3600XT 6-Core Processor
    Memory: 21.19 GB / 31.91 GB
  Binaries:
    Node: 18.16.0 - C:\Program Files\nodejs\node.EXE
    npm: 9.5.1 - C:\Program Files\nodejs\npm.CMD
    pnpm: 8.6.1 - ~\AppData\Local\pnpm\pnpm.CMD
  Browsers:
    Edge: Spartan (44.19041.1266.0), Chromium (114.0.1823.67)    
    Internet Explorer: 11.0.19041.1566
  npmPackages:
    vite: ^4.4.1 => 4.4.1

Used Package Manager

pnpm

Logs

No response

Validations

• Follow our Code of Conduct
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
• The provided reproduction is a minimal reproducible example of the bug.

[github-actions]

Hello @SiNONiMiTY. Please provide a minimal reproduction using a GitHub repository or StackBlitz. Issues marked with need reproduction will be closed if they have no activity within 3 days.

[stackblitz]

Start a new pull request in StackBlitz Codeflow.

• stackblitz-starters-nvauxh (Open reproduction)

[zonemeen]

The issue seems to be caused by @sveltejs/kit/vite.

[hackape]

This error can easily be triggered by hitting "r" key in CLI to restart the server.
@zonemeen Do you have more info to share? I'm using sveltekit and also encounter this issue wite vite v4.4.0+.

[hackape]

Call stack shows this originates from align_exports function call in "@sveltejs/kit/vite", where it calls await vite.ssrLoadModule(...);. This happens in sveltekit plugin's "configureServer" hook, which is tapped when vite restartServer.

And since server._restartPromise = restartServer(server), but vite.ssrLoadModule will eventually call loadAndTransform containing this line: if (server._restartPromise) throwClosedServerError(), this error is always thrown.

This is introduced in #13262.

[RBird111]

@hackape
Thanks for the background info! Going through it seems like there's already a guard on the server.restart() method so the new ones are redundant?
At any rate it looks like downgrading to Vite version 4.3.9 fixes the issue.