chore: Remove dead code

[piotr-cz]

Description

At given point event.isExternal has already been evaluated to be undefined

vite-plugin-pwa/src/client/build/register.ts

Line 94 in bee73ad

if (typeof event.isExternal !== 'undefined') {

so it's value cannot be truthy.

Linked Issues

none

Additional Context

I'm just trying to understand how the client-side logic works

[netlify]

✅ Deploy Preview for vite-plugin-pwa-legacy ready!

Name	Link
🔨 Latest commit	01d3788
🔍 Latest deploy log	https://app.netlify.com/sites/vite-plugin-pwa-legacy/deploys/673baaa4a328580008e6e197
😎 Deploy Preview	https://deploy-preview-788--vite-plugin-pwa-legacy.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[userquin]

The logic is in worbox window, it is not documented and it ss hard to test, yoi need 2 or more tabs and 2 browser instances. Then fire the update from the tabs and from the other instance: depending who installed/activated the new sw the flag May change.

I forgot to mention you need to await 1 minute between builds, the heuristic algorithmn used in workbox-window will give wrong flags in the event.

[piotr-cz]

Here is the diff with comments:

  if (typeof event.isExternal !== 'undefined') {
    if (event.isExternal)
      showSkipWaitingPrompt()
    else
      !onNeedRefreshCalled && onOfflineReady?.()
  }
  else {
-   if (event.isExternal) // This is never truthy, because `typeof event.isExternal === 'undefined'` (see line 1)
-     window.location.reload()
-   else
      !onNeedRefreshCalled && onOfflineReady?.()
  }