Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with SPA #54

Open
hamishjohnson opened this issue May 22, 2023 · 1 comment
Open

Issues with SPA #54

hamishjohnson opened this issue May 22, 2023 · 1 comment

Comments

@hamishjohnson
Copy link

Following on from here: #52

I ran into more issues, specifically that loading routes from the server other than the home screen (which had been precached) causes issues as they have not been precached. It's not possible for me to precache all routes because some are dynamic.

To be honest, I don't know if this is a problem relating to this package or sveltekit, and in the end I've migrated everything to pure svelte, instead of using sveltekit. But I thought I would just notify you here in case it's of interest to you.

@userquin
Copy link
Member

userquin commented May 22, 2023

@hamishjohnson you should exclude any dynamic route adding offline support for those routes or api calls

EDIT: for example, in elk repo we exclude a few api and routes from being intercepted https://github.com/elk-zone/elk/blob/main/service-worker/sw.ts#L36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants