Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vita-libs-gen-2 was added without apparent reason and is undocumented #246

Open
CelesteBlue-dev opened this issue Sep 22, 2023 · 3 comments

Comments

@CelesteBlue-dev
Copy link

vita-libs-gen-2 was added by commit f249122 but is not declared in the README.

vita-libs-gen-2 was added without apparent reason because there already exists vita-libs-gen. If there is a reason, please write it in the README.

@CelesteBlue-dev
Copy link
Author

Thank you for documenting. @Princess-of-Sleeping please also write in README.md under vita-libs-gen the limitations it has, for example the 1024 limit.

Could we remove vita-libs-gen then rename vita-libs-gen-2 to vita-libs-gen? This way, we do not have a duplicate tool and can keep backward compatibility.

@d3m3vilurr
Copy link
Contributor

yes. we planned it. keeping old one is only one reason which is checking break cases.
(actually it was also a reason why it was undocumented)

@Princess-of-Sleeping if it is ready, we go to replace old libs-gen

@d3m3vilurr
Copy link
Contributor

she reported lib-gen-2 has some broken changes. so, we'll list up it & we will have deprecation period before replacing it if we cannot resolve all of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant