Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/quote path to vdpm #49

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Selman555
Copy link

Added quotes to the includes so that directory with spaces are recognized correctly

@Selman555
Copy link
Author

Sorry about the conflicts 🥇
My previous commit will fix that.
Tested an working 💯

@d3m3vilurr
Copy link
Contributor

dont say "sorry". I occured conflicting :p
I'll review it tonight.
ty your contribution :)

tar xf "vitasdk-nightly.tar.bz2" -C $INSTALLDIR --strip-components=1
mkdir -p $INSTALLDIR &&
wget -O "vitasdk-nightly.tar.bz2" "$(get_download_link master osx)" &&
tar xf "vitasdk-nightly.tar.bz2" -C $INSTALLDIR --strip-components=1 &&
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why add &&?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also it's possible to pipe wget into tar and avoid a temporary .tar.bz file on disk
wget -O- ... | tar x -C ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants