Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up app settings #818

Open
alee opened this issue Nov 3, 2022 · 1 comment
Open

clean up app settings #818

alee opened this issue Nov 3, 2022 · 1 comment
Labels

Comments

@alee
Copy link
Member

alee commented Nov 3, 2022

settings are currently an ad hoc mess split across

  • server
  • shared
  • client

look into unifying these in a cleaner way

on the server side look into unifying in-memory settings, env settings, redis settings, etc

@alee alee added the refactor label Nov 3, 2022
@sgfost
Copy link
Contributor

sgfost commented Dec 28, 2022

client settings

This was unused, removed in 10b3aa7

shared settings

6b2b4e9 and 4ce6bff deal with cleaning up and adding some new fields that are accessed by either the client or both the client and server

This module contains isDev() and similar helper functions to test what environment we're in. 75b2ddc replaced some instances of using server settings to check for devmode with isDev(). Makes sense to continue using these for consistency

server settings

2 modules for server-only settings: static and dynamic (using redis store). 75b2ddc moves lobby settings over to the dynamic settings.

These could still use some refactoring: either unifying or disambiguating

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants