Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor global css #769

Open
alee opened this issue Feb 3, 2022 · 0 comments
Open

refactor global css #769

alee opened this issue Feb 3, 2022 · 0 comments
Assignees
Labels

Comments

@alee
Copy link
Member

alee commented Feb 3, 2022

  • limit the scope of global DOM element styling in main.scss to font size, font family etc., not colors
  • add game.scss with styles specific to the game UI
  • remove header global styles

Current issues

  • header modal width set to 100% is stretching past the side of the screen for the player detail modal and bot warning modal

dark text over dark background issues

  • Role header text in the player modal
  • accomplishment card text
  • events text
  • resources / inventory
  • phase information
  • other players
@alee alee added the bug Something isn't working label Feb 3, 2022
@alee alee closed this as completed in b289cd1 Feb 3, 2022
@alee alee reopened this Feb 3, 2022
chrstngyn pushed a commit to chrstngyn/port-of-mars that referenced this issue Feb 4, 2022
remove unused styles.scss for now until we resolve virtualcommons#769

Co-authored-by: chrstngyn <[email protected]>
@sgfost sgfost added client Client Side refactor and removed bug Something isn't working labels Jan 14, 2023
@sgfost sgfost self-assigned this Jan 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants