Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for Linux desktop #146

Open
AntoineChalons opened this issue Oct 21, 2021 · 13 comments
Open

add support for Linux desktop #146

AntoineChalons opened this issue Oct 21, 2021 · 13 comments

Comments

@AntoineChalons
Copy link

It would be great if Caraya could be fully functional on LabVIEW for Linux.

A first step would be to "simply" use Conditional Disable Structure to wrap whatever is not supported on Linux so that at least the Caraya stuff wouldn't appear as "broken" on Linux.

@jimkring
Copy link
Contributor

jimkring commented Oct 21, 2021 via email

@AntoineChalons
Copy link
Author

Absolutely!
If it's ok with you, I can fork the repo, do the fixes and create a pull request.

@jimkring
Copy link
Contributor

jimkring commented Oct 21, 2021 via email

@AntoineChalons
Copy link
Author

Ha... I forgot about that. I only have 2017, 2019 and 2020.
So I'll list keep a list.

@jimkring
Copy link
Contributor

jimkring commented Oct 21, 2021 via email

@AntoineChalons
Copy link
Author

So it was not too difficult to fix.
But it might be specific to some LV versions, I only tested this on Ubuntu 20 with LabVIEW 2020-64bit.
I had to fix 2 things :

  1. ~/vi.lib/addons/_JKI Toolkits/Caraya/classes/Basic Test Manager/Process.vi
    in this one I remove the Event Structure case that handle "double clic on the tree"

  2. wrap all the "General Error Handler.vi" into a conditional disable structure, make default case no nothing and target=windows use the GEH vi
    why? because a subVI of GEH vi is broken due to the fact that on Linux the Event Structure handles "key down" events differently than on Windows (not sure about the details tough.
    Carefull here because in the OpenG dependencies of Caraya "some" VIs call the GEH vi (only List Directory Recursive I think).

Apparently in LabVIEW 2021 the GEH vi is not broken, at least that's what NI support told me.
So now I'm wandering if the issue isn't specific to LabVIEW on Ubuntu which is not - yet - officially supported by NI

To wrap it up, I think you should assume that GEH works and do nothing about it and simply not try to handle the double clic event on the tree or any "key down?" event when on Linux.

@francois-normandin
Copy link
Collaborator

francois-normandin commented Oct 22, 2021

@AntoineChalons thanks for the report.
We could try to replace the double-click with a single click and add a way to monitor for it twice in rapid succession... It would be a shame if Linux users could not navigate to the failed assertion directly from the report.

Can you confirm that "Mouse Down" event is supported on your Linux distro?
You mention "Key Down?", but I assume that "Key Down" is fine, right?

@jimkring
Copy link
Contributor

jimkring commented Oct 22, 2021 via email

@jimkring
Copy link
Contributor

jimkring commented Oct 22, 2021 via email

@AntoineChalons
Copy link
Author

@francois-normandin @jimkring

  • GEH issue : The issue seems to be linked to my Linux distro (ubuntu 20), I have an open SRQ with NI to investigate this.
  • event struct issue : François's suggestion sounds good, but due to my distro issue, I'm even wandering if this is not broken "only for me"
    I'll try to get a clean Linux VM + LabVIEW from NI.

@francois-normandin
Copy link
Collaborator

@AntoineChalons Thanks. We'll wait for your confirmation.

@AntoineChalons
Copy link
Author

So... I got an OpenSuse Leap 15.1 VM with LabVIEW 2020-64-bit directly from NI Tech support, and there everything works.
The GEH, the event stricture catches "Key Down?" and "Double clic" events on listboxes and trees.
So the issue is not in Caraya or in LabVIEW, but in my own VM.
I'm now trying to install VIPM 2017 on this VM to check if Caraya works out of the box.

@AntoineChalons
Copy link
Author

Quick update : working hard with a colleague to build an Ubuntu VM with LabVIEW 2020 SP1 and VIPM 2017 and Caraya without all the issues described above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants