Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regex captures url() #14

Open
rdallasgray opened this issue Nov 3, 2014 · 1 comment
Open

Regex captures url() #14

rdallasgray opened this issue Nov 3, 2014 · 1 comment

Comments

@rdallasgray
Copy link

Hey -- the standard regex (https://github.com/vincentmac/gulp-fingerprint/blob/master/index.js#L22) uses the star operator to capture urls, which results in, e.g., url() being matched, with no capture group. That then causes a failure because the code here https://github.com/vincentmac/gulp-fingerprint/blob/master/index.js#L58 returns the match index, not the matched text.

This won't happen if you use the + operator instead.

Sorry I don't have time to create a PR or tests for this -- thought at least I could let you know.

@mvx24
Copy link

mvx24 commented Dec 4, 2014

It looks like the standard regex also captures and removes hash fragments and query strings, which isn't desired in my case. The replace mode seems to work better for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants