From 062e9fd18dc3188c917be89afd988e151971a184 Mon Sep 17 00:00:00 2001 From: Evan Shaw Date: Mon, 25 Nov 2024 09:27:11 +1300 Subject: [PATCH] Remove usage of E_STRICT This constant is deprecated in PHP 8.4. All E_STRICT warnings were converted to E_NOTICE in PHP 8.0. Psalm 5 still supports PHP 7.4, so _technically_ this constant could still be useful for people running it on that version, but I suspect most development and testing happens against 8.0+. It doesn't seem worth more complicated version detection in this code to me. --- src/Psalm/Internal/ErrorHandler.php | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/Psalm/Internal/ErrorHandler.php b/src/Psalm/Internal/ErrorHandler.php index e4b1b44966f..13c32561081 100644 --- a/src/Psalm/Internal/ErrorHandler.php +++ b/src/Psalm/Internal/ErrorHandler.php @@ -14,7 +14,6 @@ use function set_exception_handler; use const E_ALL; -use const E_STRICT; use const STDERR; /** @@ -59,7 +58,7 @@ private function __construct() private static function setErrorReporting(): void { - error_reporting(E_ALL | E_STRICT); + error_reporting(E_ALL); ini_set('display_errors', '1'); }