Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why my two merged pull requests was removed? #13

Closed
medzhidov opened this issue Sep 24, 2016 · 3 comments
Closed

Why my two merged pull requests was removed? #13

medzhidov opened this issue Sep 24, 2016 · 3 comments

Comments

@medzhidov
Copy link
Contributor

No description provided.

@viktorlarsson
Copy link
Owner

I had to revert the last pull request that I merged due to the code that you supplied broke the plugin for me and other users. I need to implement tests first. See issue #11

@medzhidov
Copy link
Contributor Author

I use this plugin with last pull request without any errors, and filepath was very useful. And so I must fork this repo and create new node package for comfortable work with this plugin.

@viktorlarsson
Copy link
Owner

viktorlarsson commented Sep 28, 2016

Unfortunately your code broke both my build and others (see #10)

You can still use that specific version in package.json

"devDependencies": { "gulp-inject-svg": "^0.1.6" }

Until I, or someone else, implement tests I will try to implement your pull request again.

I have made an issue for creating tests here, if you would like to help #11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants