Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interrupt armor has black background and a weird loading behaviour. #101

Open
Nikki1993 opened this issue Aug 1, 2014 · 2 comments
Open
Labels

Comments

@Nikki1993
Copy link

Interrupt armor icon is loaded after the target frame fade in animation has completed but unloads before the target frame fades out. Here is the video https://www.youtube.com/watch?v=SxtQuOi0g_s&feature=youtu.be

@Nikki1993 Nikki1993 changed the title Interrupt armor has black background and has a weird loading behaviour. Interrupt armor has black background and a weird loading behaviour. Aug 1, 2014
@itsthatguy
Copy link
Member

what's the expected behavior?

@Nikki1993
Copy link
Author

@itsthatguy There are different ways to achieve a certain behaviour but the core idea is "Time is everything". You have to see interrupt atmor on the target frame as soon as you clicked on it, not waiting any second for the icon to appear.

Solution number 1:
Make so that the fade in animation of the TargetFrame is synced with the fade in animation of the interrupt armor icon and same goes for releasing the TargetFrame.

Solution number 2:
If you cannot achieve a total sync due to how addons/resources are loaded, the best workaround, in my opinion, would be to load interrupt icon immediately without waiting for TargetFrame fade in animation to complete. In raids/dungeons/adventures it is essential to see the Interrupt armor of the creature as soon as you click the frame.

Additional feature: Set the icon transparency level same as Unitframes one. Right now it's just a small black box which looks inconsistently with other UI elements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants