Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong current when using option "allowExpandAll: true" #64

Open
tung13041996 opened this issue Apr 12, 2024 · 0 comments
Open

Wrong current when using option "allowExpandAll: true" #64

tung13041996 opened this issue Apr 12, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@tung13041996
Copy link
Member

tung13041996 commented Apr 12, 2024

Why

With option allowExpandAll: true, the issue go with this picture for example

Untitled-1

After re-check, I see that method afterClose on line 256 doesn't update current_id
image

Solution here:

  • We must update current_id on line 256
// update current id
this.current_id = panel.id;

// update target
const object = this.options.allowExpandAll ?
    {
        type: this.type,
        current_id: this.current_id,
        previous_id: this.previous_id
    } : target;
// fire event
this.events.fire('onAfterClose', object);
@tung13041996 tung13041996 self-assigned this Apr 12, 2024
@tung13041996 tung13041996 added the bug Something isn't working label Apr 12, 2024
@tung13041996 tung13041996 changed the title Wrong previous when using option "allowExpandAll: true" Wrong current when using option "allowExpandAll: true" Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant