Relax video.js version range to allow version 8

[andreas-venturini]

Description

Would be great if the version range could be relaxed to allow video.js 8

videojs-vr/package.json

Line 84 in fb110c9

"video.js": "^6 || ^7",

[maikgramatte]

Hi @andreas-venturini

I did have the same problem:

{
  "name": "videojs-vr",
  "version": "2.0.0",
  "description": "A plugin to add 360 and VR video support to video.js.",
  "author": {
    "name": "James Broberg",
    "email": "[email protected]"
  },
  "contributors": [
    {
      "name": "Sean Lawrence",
      "email": "[email protected]"
    },
    {
      "name": "Mitchell Trent",
      "email": "[email protected]"
    },
    {
      "name": "Brandon Casey",
      "email": "[email protected]"
    }
  ],
  "license": "MIT",
  "repository": {
    "type": "git",
    "url": "https://github.com/videojs/videojs-vr"
  },
  "main": "dist/videojs-vr.cjs.js",
  "module": "dist/videojs-vr.es.js",
  "generator-videojs-plugin": {
    "version": "9.0.0"
  },
  "scripts": {
    "netlify": "npm run build && node scripts/netlify.js",
    "build-test": "cross-env-shell TEST_BUNDLE_ONLY=1 'npm run build'",
    "build-prod": "cross-env-shell NO_TEST_BUNDLE=1 'npm run build'",
    "build": "npm-run-all -s clean -p build:*",
    "build:js": "rollup -c scripts/rollup.config.js",
    "build:css": "sass --no-source-map src/plugin.scss dist/videojs-vr.css",
    "build:lang": "vjslang --dir dist/lang",
    "clean": "shx rm -rf ./dist ./test/dist && shx mkdir -p ./dist ./test/dist",
    "lint": "vjsstandard",
    "prepublishOnly": "npm-run-all build-prod && vjsverify --skip-require --verbose --skip-syntax",
    "start": "npm-run-all -p server watch",
    "server": "karma start scripts/karma.conf.js --singleRun=false --auto-watch",
    "test": "npm run build-test && karma start scripts/karma.conf.js",
    "posttest": "shx cat test/dist/coverage/text.txt",
    "version": "is-prerelease || npm run update-changelog && git add CHANGELOG.md",
    "update-changelog": "conventional-changelog -p videojs -i CHANGELOG.md -s",
    "watch": "npm-run-all -p watch:*",
    "watch:js": "npm run build:js -- -w",
    "watch:css": "npm run build:css -- -w"
  },
  "keywords": [
    "videojs",
    "videojs-plugin"
  ],
  "vjsstandard": {
    "ignore": [
      "dist",
      "docs",
      "vendor",
      "test/dist"
    ]
  },
  "files": [
    "CONTRIBUTING.md",
    "dist/",
    "docs/",
    "index.html",
    "scripts/",
    "src/",
    "test/"
  ],
  "greenkeeper": {
    "ignore": [
      "three"
    ]
  },
  "dependencies": {
    "@babel/runtime": "^7.14.5",
    "global": "^4.4.0",
    "three": "0.125.2",
    "video.js": "8",
    "webvr-polyfill": "0.10.12"
  },
  "devDependencies": {
    "@videojs/generator-helpers": "3.2.0",
    "karma": "^6.3.4",
    "omnitone": "^1.3.0",
    "rollup": "2.42.0",
    "rollup-plugin-re": "^1.0.7",
    "sass": "^1.34.1",
    "sinon": "^7.2.2",
    "videojs-generate-karma-config": "8.0.1",
    "videojs-generate-rollup-config": "7.0.1",
    "videojs-generator-verify": "~4.0.0",
    "videojs-languages": "^2.0.0",
    "videojs-standard": "9.0.1"
  },
  "lint-staged": {
    "*.js": "vjsstandard --fix",
    "README.md": "doctoc --notitle"
  },
  "husky": {
    "hooks": {
      "pre-commit": "lint-staged"
    }
  }
}

Ended up manually upgrading videojs-dependencies to the latest and it did work for me. video js VR is compatible with version 8 of the player.

[andreas-venturini]

Thanks for your answer @maikgramatte, we ended up doing the same and it worked for us as well (for our use case anyway)
The only downside of that approach is that your js bundler will continue to pull in the video.js 7 dependency as long as the version range doesn't include version 8 (which is not a big problem but still a little annoying).