Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pytorch in requirements? #53

Open
dconathan opened this issue Sep 21, 2020 · 3 comments
Open

Pytorch in requirements? #53

dconathan opened this issue Sep 21, 2020 · 3 comments

Comments

@dconathan
Copy link

Both torch and torchvision are in requirements.txt and setup.py but they don't seem to be used anywhere. Any particular reason you have both torch and tensorflow in requirements?

@victordibia
Copy link
Owner

Hi @dconathan

I recall this being a requirement to load/convert HF models that do not have TF weights.
I am happy to get your thoughts on ways to completely sidestep pytorch/torchvision (as it makes the install really heavy ).
I'll investigate a bit more .. let me know if you have any additional ideas.

@dconathan
Copy link
Author

Ah that makes sense. Are you open to pytorch-only backend and eliminating tensorflow as a dependency?

@victordibia
Copy link
Owner

victordibia commented Sep 22, 2020

At this point, that seems like a good way to simply things.
I'll take a pass this weekend, articulate out an issue and post an update.
Given that the library is not more focused on usability/visual interface, it probably does not matter much if its pt or tf underneath.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants