[Android Bootcamp] TwitterClient Redux review

[vibhorB]

Pls reviw my submission for Week 4 assignment - TwitterClient Redux. I have added README.md. /cc @nesquena @timothy1ee

Hours spent :
I have spent around 10-12 hours on this assignment, spending most time in making app look twitter branded with closer colors, icons, look n feel, and behavior

Notes:

1. I was working on showing images in tweets on timeline also. But due to some reason, same image starts showing up in other tweets, so I have commented out that part. But image will be visible in Detail view for tweets.
2. I have not added screenshots yet, will do that later
3. Just realized I ended up commenting out / removing persistence (which was actually working in last week's twitter)

Required Features Completed :

1. All user stories from Week -3
2. User can switch between Timeline and Mention views using tabs.
   User can view their home timeline tweets.
   User can view the recent mentions of their username.
   User can scroll to bottom of either of these lists and new tweets will load ("infinite scroll")
3. User can navigate to view their own profile
   User can see picture, tagline, # of followers, # of following, and tweets on their profile.
4. User can click on the profile image in any tweet to see another user's profile.
   User can see picture, tagline, # of followers, # of following, and tweets of clicked user.
   Profile view should include that user's timeline

Optional features completed :

1. All optionals from week-3 listed on week-3 issue
2. Added polish to make app look Twitter branded
3. When a network request goes out, user sees an indeterminate progress indicator
4. User can view following / followers list through the profile by clicking on "x followers" or "y following" and can open profile of anyone from any of these lists also
5. User can search for tweets matching a particular query and see results
6. User can click on a tweet to be taken to a "detail view" of that tweet
7. From detail view, user can retweet, reply, favorite or unfavorite and share tweet
8. User can "reply" to any tweet on their home timeline
   The user that wrote the original tweet is automatically "@" replied in compose
9. User can retweet, favorite or unfavorite from timeline also
10. Retweet and favorite actions change icon color to show action taken
11. Images in tweet can be seen in detailed view

[nesquena]

👍 excellent work Vibhor! A few notes after checking out the code:

• Nice to see you used a drawable and/or styles to customize the view
• Nice job with including progress bar support
• Nice to see you used the SupportFragmentTabListener to properly setup the tabs!
• Good to see you properly communicated the user to the user timeline fragment from the profile activity.
• Nicely done architecting the fragments (base class and extension classes) such that you put as much code and logic as possible in the base class and then used abstract methods to define only the specific behavior where they differ!

Here's a detailed Project 4 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you might be able to improve your submission.

This week (Week 5), we are going to cover the last major piece to the Android puzzle and that is using the hardware and SDK components such as the camera, photo gallery, location, maps, etc. After that, Week 6 and week 7 we will be covering a few important intermediate topics such as more about styling and animation as well as testing.

Following the bootcamp (May 12th), we are going to have a demo day to celebrate the progress you've all made with our next batch of Android students and multiple companies attending to see the group projects that you all have built. We are going to help however we can over the next few weeks to get the team project apps in shape for that.

[nesquena]

Glad you are looking for more feedback. There's always a lot of things you can do to improve the app. The closer you get to the real twitter the app the more you will learn by a fairly substantial margin. The truth of mobile is the "hard" part is all in the details of the UI polish and the custom (non-standard stuff). You have already gotten great learnings from this assignment. You should focus your energy now on the group project. But one thing you might find as an interesting exercise is to swap the tabs for a ViewPager and try the PagerSlidingTabStrip to achieve swipe-able views that feel more like the way twitter tabs work.