[Android Bootcamp] GoogleImageSearch review

[vibhorB]

Pls reviw my submission for Week 2 assignment - GoogleImageSearch. I have added README.md along with screenshots /cc @nesquena @timothy1ee

Hours spent :
I have easily spent 12-15 hours atleast on this assignment primarily due to the number of issues I had with my emulator + getting ColorDrawable from imageView

Required Features Completed :

1. User can enter search query that will display grid of images from Google Image API
2. User can filter search results by clicking Filter
3. Subsequent results will have filter applied
4. User can tap on any image to see image full screen
5. Infinte scroll down on grid view

Optional features completed :

1. From full image view, user can share image
2. From grid view, user can long press image to open share menu
3. From full image view, user can save image to phone
4. ActionBar SearchView is used instead of EditText
5. Filter is applied to current search also when it is set
6. Clear filter by clicking Reset Filter from ActionBar
7. Toast messages in case of failures such as - No network, cannot share, download failed
8. Improved styling by using Icons, logo and background image; Filter behaves as a dialog

Issues known :

1. Share/save doesn't work on emulator at all for me since I get Permission exception on emulator
2. In full view, some images might not be shareable since sometimes the getDrawable returns a ColorDrawable, in that case we will show Toast message saying Cannot be shared.
3. Same happens when you try to share in grid view via long press. Most of the times I get ColorDrawable. Stil trying to figure this out.

[nesquena]

👍 excellent work Vibhor. A few notes after checking out the code:

• Properly reused the single base method to fetch results for both initial load and the pagination
• Nice touch adding a ImageSearchRestClient
• Nice to see you added the search to the ActionBar!
• Properly used spinners (with populated values) to allow users to select filters
• Properly send and receive relevant filters using a bundle to pass data between activities
• Good to see you used a filters object to represent the filters to apply to the query
• Nice job adding the share intent to the image detail view!

Also, here's a more detailed Project 2 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.

Let us know if you have any other thoughts or questions about this assignment. The next assignment (Twitter Client) will be especially important since it introduces the majority of the remaining pieces necessary to build a fully functional API client with complex feeds of data and user creation.