You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
GCS seems to support both files AND directories (prefixes) with the same string.
For example, gs://test_bucket/test_file.txt and gs://test_bucket/test_file.txt/sub_file.txt are both valid GCS objects.
In the case this occurs, it looks like the ZIP detection isn't handling this correctly.
Specifically, github.com/viant/afsc/gs.(s *storager).List will return multiple files in the case that both a file and a prefix exist at the same path, and github.com/viant/afs/zip.newStorager() checks to make sure the List only returns one file https://github.com/viant/afs/blob/master/zip/storager.go#L241.
The currently coded behavior seems to work on the assumption that a file and a directory cannot be the same name (which is valid).
This may also coincide with the way that afsc/gs is handling the List method, as it seems to assume that the URL provided can be a prefix.
The text was updated successfully, but these errors were encountered:
GCS seems to support both files AND directories (prefixes) with the same string.
For example,
gs://test_bucket/test_file.txt
andgs://test_bucket/test_file.txt/sub_file.txt
are both valid GCS objects.In the case this occurs, it looks like the ZIP detection isn't handling this correctly.
Specifically,
github.com/viant/afsc/gs.(s *storager).List
will return multiple files in the case that both a file and a prefix exist at the same path, andgithub.com/viant/afs/zip.newStorager()
checks to make sure theList
only returns one file https://github.com/viant/afs/blob/master/zip/storager.go#L241.The currently coded behavior seems to work on the assumption that a file and a directory cannot be the same name (which is valid).
This may also coincide with the way that
afsc/gs
is handling theList
method, as it seems to assume that the URL provided can be a prefix.The text was updated successfully, but these errors were encountered: