Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Device::getDPI() #179

Open
3 tasks
HeikoKlare opened this issue Jan 9, 2025 · 0 comments
Open
3 tasks

Replace Device::getDPI() #179

HeikoKlare opened this issue Jan 9, 2025 · 0 comments
Assignees
Labels
HiDPI A HiDPI-Related Issue or Feature SWT Issue for SWT
Milestone

Comments

@HeikoKlare
Copy link
Contributor

HeikoKlare commented Jan 9, 2025

The Device::getDPI() method does have a reasonable meaning when used while monitor-specific scaling is activated. In order to reflect this, the following needs to be done:

  1. Known usages of that method shall be replaced (at least in Eclipse Platform, in GEF Classic). Depending on the context, maybe the DPI is not even the desired information (or rather something like the zoom of a window), or a potential replacement might be the usage of per-monitor DPI (with something like OS#getDPIForMonitor()).
  2. The method shall be deprecated. Depending on the needs identified in the first point, a replacement may be provided or at least information about way to replace calls to the methods as applied in the first point shall be added to the deprecation notice.

This is a follow-up to:

@HeikoKlare HeikoKlare added SWT Issue for SWT HiDPI A HiDPI-Related Issue or Feature labels Jan 9, 2025
@HeikoKlare HeikoKlare added this to HiDPI Jan 9, 2025
@HeikoKlare HeikoKlare moved this to 🔖 Ready: Atomic in HiDPI Jan 9, 2025
@HeikoKlare HeikoKlare added this to the 4.35 M2 milestone Jan 13, 2025
@ShahzaibIbrahim ShahzaibIbrahim self-assigned this Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
HiDPI A HiDPI-Related Issue or Feature SWT Issue for SWT
Projects
Status: 🔖 Ready: Atomic
Development

No branches or pull requests

2 participants