Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplication of config structures in open_yurt scripts #942

Open
leokondrashov opened this issue Feb 20, 2024 · 1 comment
Open

Duplication of config structures in open_yurt scripts #942

leokondrashov opened this issue Feb 20, 2024 · 1 comment
Assignees
@lrq619 @jchua99
Labels
enhancement New feature or request

Comments

@leokondrashov
Copy link
Contributor

Describe the enhancement

In addition of OpenYurt deployment to the vHive, structures SystemEnvironmentStruct, KubeConfigStruct, KnativeConfigStruct significantly duplicate the existing structures in scripts/configs. That makes the code hard to maintain configs (need to update the format in several places).

The solution is to reuse existing ones instead of copy-pasting the content.
@leokondrashov leokondrashov added the enhancement New feature or request label Feb 20, 2024
@lrq619 lrq619 self-assigned this Jul 2, 2024
@lrq619
Copy link
Collaborator

lrq619 commented Jul 2, 2024

Will handle this in the next development iteration

@lrq619 lrq619 closed this as completed Jul 2, 2024
@lrq619 lrq619 reopened this Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lrq619 lrq619

@jchua99 jchua99

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@leokondrashov @lrq619 @jchua99