Skip to content

Commit f00a843

Browse files
committed
Merge branch 'master' of github.com:facebook/three20 into v1.0
2 parents db2c88c + f348ed3 commit f00a843

File tree

6 files changed

+18
-8
lines changed

6 files changed

+18
-8
lines changed

AUTHORS

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ Current Maintainers
99
-------------------
1010
Owen Yamauchi github.com/oyamauchi [email protected]
1111
Jeff Verkoeyen github.com/jverkoey [email protected]
12+
John Wang github.com/jwang [email protected]
1213

1314
Contributors
1415
------------

README.mdown

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,13 +19,17 @@ If you would like to ask any questions regarding Three20, please check out any o
1919

2020
* [Three20.info][]
2121
* [Three20 Mailing List][]
22-
* [Three20 Scope][]
22+
* [Three20 Tagged Questions on StackOverflow][]
2323

2424
Adding Three20 to your project
2525
==============================
2626

27-
Three20 is compiled as a static library, and the easiest way to add it to your
28-
project is to use Xcode's "dependent project" facilities. Here is how:
27+
Three20 is compiled as static libraries. It use Xcode's "dependent project" facilities.
28+
There are two methods of adding Three20 to your project.
29+
30+
The first is with the [TTModule Python Script][].
31+
32+
The Second option is to add it to your project manually. Here is how:
2933
**Estimated time:** 5 minutes.
3034

3135
1. Clone the three20 git repository: `git clone git://github.com/facebook/three20.git`. Make sure
@@ -155,7 +159,7 @@ Learn more at [Three20.info][]
155159
[Facebook iPhone app]: http://phobos.apple.com/WebObjects/MZStore.woa/wa/viewSoftware?id=284882215&mt=8
156160
[Three20.info]: http://Three20.info
157161
[Three20 Mailing List]: http://groups.google.com/group/three20/
158-
[Three20 Scope]: http://three20.stackexchange.com
162+
[Three20 Tagged Questions on StackOverflow]: http://stackoverflow.com/questions/tagged/three20
159163
[TTPhotoViewController]: http://github.com/facebook/three20/blob/master/src/Three20UI/Headers/TTPhotoViewController.h
160164
[TTMessageController]: http://github.com/facebook/three20/blob/master/src/Three20UI/Headers/TTMessageController.h
161165
[TTImageView]: http://github.com/facebook/three20/blob/master/src/Three20UI/Headers/TTImageView.h
@@ -165,3 +169,4 @@ Learn more at [Three20.info][]
165169
[TTTextEditor]: http://github.com/facebook/three20/blob/master/src/Three20UI/Headers/TTTextEditor.h
166170
[TTPickerTextField]: http://github.com/facebook/three20/blob/master/src/Three20UI/Headers/TTPickerTextField.h
167171
[TTNavigator]: http://github.com/facebook/three20/blob/master/src/Three20UI/Headers/TTNavigator.h
172+
[TTModule Python Script]: http://three20.info/article/2010-10-06-Adding-Three20-To-Your-Project

samples/TTNavigatorDemo/Classes/ContentController.m

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ - (id)initWithNutrition:(NSString*)food {
6969

7070
- (id)initWithAbout:(NSString*)about {
7171
if (self = [super init]) {
72-
_contentType = ContentTypeNutrition;
72+
_contentType = ContentTypeAbout;
7373
self.content = about;
7474
self.text = [NSString stringWithFormat:@"<b>%@</b> is the name of this page. Exciting.", about];
7575

@@ -113,6 +113,9 @@ - (void)loadView {
113113
self.view.backgroundColor = [UIColor grayColor];
114114
label.backgroundColor = self.view.backgroundColor;
115115
self.hidesBottomBarWhenPushed = YES;
116+
} else if (_contentType == ContentTypeAbout) {
117+
self.view.backgroundColor = [UIColor grayColor];
118+
label.backgroundColor = self.view.backgroundColor;
116119
} else if (_contentType == ContentTypeOrder) {
117120
UIButton* button = [UIButton buttonWithType:UIButtonTypeRoundedRect];
118121
[button setTitle:@"What do you want to eat?" forState:UIControlStateNormal];

src/Three20UI/Sources/TTSectionedDataSource.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -219,7 +219,7 @@ - (BOOL)removeItemAtIndexPath:(NSIndexPath*)indexPath andSectionIfEmpty:(BOOL)an
219219
if (_sections.count) {
220220
NSMutableArray* items = [_items objectAtIndex:indexPath.section];
221221
[items removeObjectAtIndex:indexPath.row];
222-
if (!items.count) {
222+
if (andSection && !items.count) {
223223
[_sections removeObjectAtIndex:indexPath.section];
224224
[_items removeObjectAtIndex:indexPath.section];
225225
return YES;

src/Three20UI/Sources/TTTableMessageItemCell.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ - (void)layoutSubviews {
148148
_timestampLabel.top = _titleLabel.top;
149149
_titleLabel.width -= _timestampLabel.width + kTableCellSmallMargin*2;
150150
} else {
151-
_titleLabel.frame = CGRectZero;
151+
_timestampLabel.frame = CGRectZero;
152152
}
153153
}
154154

src/Three20UI/Sources/TTWebController.m

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -317,6 +317,7 @@ - (void)webViewDidStartLoad:(UIWebView*)webView {
317317
if (!self.navigationItem.rightBarButtonItem) {
318318
[self.navigationItem setRightBarButtonItem:_activityItem animated:YES];
319319
}
320+
[UIApplication sharedApplication].networkActivityIndicatorVisible = YES;
320321
[_toolbar replaceItemWithTag:3 withItem:_stopButton];
321322
_backButton.enabled = [_webView canGoBack];
322323
_forwardButton.enabled = [_webView canGoForward];
@@ -326,7 +327,7 @@ - (void)webViewDidStartLoad:(UIWebView*)webView {
326327
///////////////////////////////////////////////////////////////////////////////////////////////////
327328
- (void)webViewDidFinishLoad:(UIWebView*)webView {
328329
TT_RELEASE_SAFELY(_loadingURL);
329-
330+
[UIApplication sharedApplication].networkActivityIndicatorVisible = NO;
330331
self.title = [_webView stringByEvaluatingJavaScriptFromString:@"document.title"];
331332
if (self.navigationItem.rightBarButtonItem == _activityItem) {
332333
[self.navigationItem setRightBarButtonItem:nil animated:YES];

0 commit comments

Comments
 (0)